[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183067115 Yup that's a great idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183066436 We could add a unit test for this specific case. But I am also looking for a way to treat these warnings as compile errors; which would be a lot better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183061509 Can we add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183044450 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182913207 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182895732 @hvanhovell there are two alternatives to match `tableProvider` rule: tableProvider tableOpts? (KW_AS selectStatementWithCTE)? And (LPAREN columnNameTypeList RPAREN)? (p=tableProvider?) ... Because `(LPAREN columnNameTypeList RPAREN)` is optional, an input `KW_USING Identifier` can be matched with both paths. So the warning is emitted and path 1 is chosen and path 2 is disabled. Actually it doesn't affect the functionality we need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182870348 @viirya thanks for working on this. Do you have an idea what functionality was disabled? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182781741 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51089/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182781740 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182781527 **[Test build #51089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51089/consoleFull)** for PR 11168 at commit [`4cb9d2a`](https://github.com/apache/spark/commit/4cb9d2a0401d10277195c7853999cc89a0853abd). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182758075 **[Test build #51089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51089/consoleFull)** for PR 11168 at commit [`4cb9d2a`](https://github.com/apache/spark/commit/4cb9d2a0401d10277195c7853999cc89a0853abd). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182754237 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/11168 [SPARK-13277][SQL] ANTLR ignores other rule using the USING keyword JIRA: https://issues.apache.org/jira/browse/SPARK-13277 There is an ANTLR warning during compilation: warning(200): org/apache/spark/sql/catalyst/parser/SparkSqlParser.g:938:7: Decision can match input such as "KW_USING Identifier" using multiple alternatives: 2, 3 As a result, alternative(s) 3 were disabled for that input This patch is to fix it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/viirya/spark-1 fix-parser-using Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11168 commit 4cb9d2a0401d10277195c7853999cc89a0853abd Author: Liang-Chi Hsieh Date: 2016-02-11T07:49:42Z Fix an ANTLR warning during compilation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
