[GitHub] spark pull request: [SPARK-13363][SQL] support Aggregator in DataF...
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/12359 [SPARK-13363][SQL] support Aggregator in DataFrame ## What changes were proposed in this pull request? set the input encoder for `TypedColumn` in `RelationalGroupedDataset.agg`. ## How was this patch tested? new tests in `DatasetAggregatorSuite` close https://github.com/apache/spark/pull/11269 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark agg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12359 commit f4ec1ef138dba21640485d1d8acd1114156671ab Author: Wenchen FanDate: 2016-04-13T12:47:07Z support Aggregator in DataFrame --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user maropu closed the pull request at: https://github.com/apache/spark/pull/11269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186943609 @maropu mind closing this for now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186571725 @cloud-fan okay, after the merging finished, I'll revisit this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186234980 We are merging DataFrame and Dataset now, I think we should revisit this PR after that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186219892 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186219900 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51556/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186219376 **[Test build #51556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51556/consoleFull)** for PR 11269 at commit [`58205e2`](https://github.com/apache/spark/commit/58205e2e4c66e83d6cc1761daa3ca490da23097d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186199631 **[Test build #51556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51556/consoleFull)** for PR 11269 at commit [`58205e2`](https://github.com/apache/spark/commit/58205e2e4c66e83d6cc1761daa3ca490da23097d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186194169 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186182221 **[Test build #51550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51550/consoleFull)** for PR 11269 at commit [`58205e2`](https://github.com/apache/spark/commit/58205e2e4c66e83d6cc1761daa3ca490da23097d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186182478 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51550/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186182475 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11269#issuecomment-186160060 **[Test build #51550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51550/consoleFull)** for PR 11269 at commit [`58205e2`](https://github.com/apache/spark/commit/58205e2e4c66e83d6cc1761daa3ca490da23097d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13363][SQL] Support Aggregator in DataF...
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/11269 [SPARK-13363][SQL] Support Aggregator in DataFrame Support user-defined `Aggregator`s in DataFrame. Currently, the code below does not work because of an unresolved error in `CheckAnalysis`. ``` val simpleSum = new SqlAggregator[Int, Int, Int] { def zero: Int = 0 // The initial value. def reduce(b: Int, a: Int) = b + a// Add an element to the running total def merge(b1: Int, b2: Int) = b1 + b2 // Merge intermediate values. def finish(b: Int) = b// Return the final result. }.toColumn val df = sc.makeRDD(1 to 3).map(i => (i, i)).toDF("k", "v") df.groupBy("k").agg(simpleSum).show ``` This pr fix this and add tests according to `DatasetAggregatorSuite`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/maropu/spark SupportAggregatorInDF Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org