[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-187017636 @dbtsai Thanks! I will send another PR for consistent convergence tolerance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186998722 LGTM. Merged into master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186994891 The default value in R's GLMNET is `1E-7`, and the default value in original LBFGS implementation is `1E-8`. In order to provide better and consistent result, let's change it to `1E-6` in a separate PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186973326 @dbtsai I have copied tests from ML. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186796257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186796262 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51621/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186796153 **[Test build #51621 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51621/consoleFull)** for PR 11258 at commit [`8f0fcfa`](https://github.com/apache/spark/commit/8f0fcfab2fe9df3de680732d20c671c994be8236). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186789150 **[Test build #51621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51621/consoleFull)** for PR 11258 at commit [`8f0fcfa`](https://github.com/apache/spark/commit/8f0fcfab2fe9df3de680732d20c671c994be8236). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186153756 OK, I will copy tests from ML. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186088729 +1 on copying the tests from ML LOR tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186081215 Yep, I cleaned up the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186054750 So this wasn't really tested by unit tests ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186053381 This is due to we don't have excellent test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186052919 Regarding testing: how does this work with unit tests? If the old code passes all the tests ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186052851 Thanks - I was checking to see if the template shows up or not, because a number of pull requests don't follow it. I think it's a good idea to follow this as much as possible, since it'd encourage the newer contributors to actually think about testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186052209 @rxin I saw the template, but I think this change is very easy to understand, so ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186051411 Question: do you see the pull request template? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186041765 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186041693 **[Test build #51514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51514/consoleFull)** for PR 11258 at commit [`1a69b78`](https://github.com/apache/spark/commit/1a69b7866d23428c1661c7dd7abe00c31c60b6fe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186041766 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51514/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186029364 **[Test build #51514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51514/consoleFull)** for PR 11258 at commit [`1a69b78`](https://github.com/apache/spark/commit/1a69b7866d23428c1661c7dd7abe00c31c60b6fe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
