[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192477152 Here is the JIRA Issue [SPARK-13686](https://issues.apache.org/jira/browse/SPARK-13686) and [PR](https://github.com/apache/spark/pull/11527). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192470061 Hi, @srowen . According to your advice, I reviewed the other algorithms and I found that all other algorithms use the same default values for `reqParam` in Scala/Python. It's a good new. * ALS: 0.1 * LassoWithSGD: 0.01 * LinearRegression: 0.0 * LinearRegressionWithSGD: 0.0 * LogisticRegression: 0.0 * LogisticRegressionWithSGD: 0.01 * LogisticRegressionWithLBFGS: 0.00 * RidgeRegressionWithSGD: 0.01 * SVMWithSGD: 0.01 * StreamingLogisticRegressionWithSGD: 0.0 However, I found that `LinearRegressionWithSGD` and `StreamingLinearRegressionWithSGD` does not have `regParam` as constructor arguments. They just depends on `GradientDescent`'s default `reqParam` values. So, I think we need to file this as a new JIRA issue. Thank you, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192349163 Also, thank you for Coverity, @srowen ! Today, I will check them, too. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192347677 I see, @srowen . I will check the others, too. Thank you, @srowen and @mengxr . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192342877 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192262160 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52464/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192262154 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192261681 **[Test build #52464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52464/consoleFull)** for PR 11519 at commit [`d5323af`](https://github.com/apache/spark/commit/d5323af4383e9fbebea30af51801bc9f623822aa). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192258156 **[Test build #52464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52464/consoleFull)** for PR 11519 at commit [`d5323af`](https://github.com/apache/spark/commit/d5323af4383e9fbebea30af51801bc9f623822aa). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192257367 Sounds good. If you have a moment would be good to look over other default regularization params to see if there are other mismatches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192257227 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11519#issuecomment-192256061 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13676] Fix mismatched default values fo...
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11519 [SPARK-13676] Fix mismatched default values for regParam in LogisticRegression ## What changes were proposed in this pull request? The default value of regularization parameter for `LogisticRegression` algorithm is different in Scala and Python. We should provide the same value. **Scala** ``` scala> new org.apache.spark.ml.classification.LogisticRegression().getRegParam res0: Double = 0.0 ``` **Python** ``` >>> from pyspark.ml.classification import LogisticRegression >>> LogisticRegression().getRegParam() 0.1 ``` ## How was this patch tested? manual. Check the following in `pyspark`. ``` >>> from pyspark.ml.classification import LogisticRegression >>> LogisticRegression().getRegParam() 0.0 ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/dongjoon-hyun/spark SPARK-13676 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11519.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11519 commit d5323af4383e9fbebea30af51801bc9f623822aa Author: Dongjoon Hyun Date: 2016-03-04T11:54:19Z [SPARK-13676] Fix mismatched default values for regParam in LogisticRegression --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
