[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-196214875 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-196051051 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53035/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-196051048 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-196050740 **[Test build #53035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53035/consoleFull)** for PR 11580 at commit [`bb8b83a`](https://github.com/apache/spark/commit/bb8b83a9dbc442d48a2acdc3c62bfe6646b61178). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-196016180 **[Test build #53035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53035/consoleFull)** for PR 11580 at commit [`bb8b83a`](https://github.com/apache/spark/commit/bb8b83a9dbc442d48a2acdc3c62bfe6646b61178). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user wilson8 commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55941313 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -578,18 +578,27 @@ class CleanerTester( } private def uncleanedResourcesToString = { +val s1 = {toBeCleanedRDDIds.synchronized { --- End diff -- @srowen Sorry, I overlooked this. Will change now. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55935805 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -578,18 +578,27 @@ class CleanerTester( } private def uncleanedResourcesToString = { +val s1 = {toBeCleanedRDDIds.synchronized { --- End diff -- These two statements have extra braces --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55935798 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -442,25 +442,25 @@ class CleanerTester( checkpointIds: Seq[Long] = Seq.empty) extends Logging { - val toBeCleanedRDDIds = new HashSet[Int] with SynchronizedSet[Int] ++= rddIds - val toBeCleanedShuffleIds = new HashSet[Int] with SynchronizedSet[Int] ++= shuffleIds - val toBeCleanedBroadcstIds = new HashSet[Long] with SynchronizedSet[Long] ++= broadcastIds - val toBeCheckpointIds = new HashSet[Long] with SynchronizedSet[Long] ++= checkpointIds + val toBeCleanedRDDIds = new HashSet[Int] ++= rddIds --- End diff -- Ah right Scala doesn't have a constructor that builds a set from a list/seq, so this makes a set of a `Seq[Int]`. Yes this is fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195931183 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195931184 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53024/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195931137 **[Test build #53024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53024/consoleFull)** for PR 11580 at commit [`c1e4e41`](https://github.com/apache/spark/commit/c1e4e41f5e85411cc3073204aadca1d1418304df). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195911950 **[Test build #53024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53024/consoleFull)** for PR 11580 at commit [`c1e4e41`](https://github.com/apache/spark/commit/c1e4e41f5e85411cc3073204aadca1d1418304df). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user wilson8 commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55933247 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -579,17 +579,20 @@ class CleanerTester( private def uncleanedResourcesToString = { s""" - |\tRDDs = ${toBeCleanedRDDIds.toSeq.sorted.mkString("[", ", ", "]")} - |\tShuffles = ${toBeCleanedShuffleIds.toSeq.sorted.mkString("[", ", ", "]")} - |\tBroadcasts = ${toBeCleanedBroadcstIds.toSeq.sorted.mkString("[", ", ", "]")} + |\tRDDs = ${toBeCleanedRDDIds.synchronized --- End diff -- @srowen I will change this. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user wilson8 commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55933241 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -442,25 +442,25 @@ class CleanerTester( checkpointIds: Seq[Long] = Seq.empty) extends Logging { - val toBeCleanedRDDIds = new HashSet[Int] with SynchronizedSet[Int] ++= rddIds - val toBeCleanedShuffleIds = new HashSet[Int] with SynchronizedSet[Int] ++= shuffleIds - val toBeCleanedBroadcstIds = new HashSet[Long] with SynchronizedSet[Long] ++= broadcastIds - val toBeCheckpointIds = new HashSet[Long] with SynchronizedSet[Long] ++= checkpointIds + val toBeCleanedRDDIds = new HashSet[Int] ++= rddIds --- End diff -- @srowen I tried to change to val toBeCleanedRDDIds = HashSet(rddIds), but I got error at toBeCleanedRDDIds -= rddId so I will keep val toBeCleanedRDDIds = new HashSet[Int] ++= rddIds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195657855 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195657858 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52968/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195657820 **[Test build #52968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52968/consoleFull)** for PR 11580 at commit [`6721259`](https://github.com/apache/spark/commit/6721259bdda69f66e30fcd59f207f63c1a86440f). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195611810 **[Test build #52968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52968/consoleFull)** for PR 11580 at commit [`6721259`](https://github.com/apache/spark/commit/6721259bdda69f66e30fcd59f207f63c1a86440f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-195611297 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-194709904 This needs a rebase anyway so I left a few more comments. Otherwise LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55641453 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -579,17 +579,20 @@ class CleanerTester( private def uncleanedResourcesToString = { s""" - |\tRDDs = ${toBeCleanedRDDIds.toSeq.sorted.mkString("[", ", ", "]")} - |\tShuffles = ${toBeCleanedShuffleIds.toSeq.sorted.mkString("[", ", ", "]")} - |\tBroadcasts = ${toBeCleanedBroadcstIds.toSeq.sorted.mkString("[", ", ", "]")} + |\tRDDs = ${toBeCleanedRDDIds.synchronized --- End diff -- At this point it's getting hard to read this in the interpolated string. I'd just pull out the calls to `mkString` and save them as `val`s. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55641420 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -442,25 +442,25 @@ class CleanerTester( checkpointIds: Seq[Long] = Seq.empty) extends Logging { - val toBeCleanedRDDIds = new HashSet[Int] with SynchronizedSet[Int] ++= rddIds - val toBeCleanedShuffleIds = new HashSet[Int] with SynchronizedSet[Int] ++= shuffleIds - val toBeCleanedBroadcstIds = new HashSet[Long] with SynchronizedSet[Long] ++= broadcastIds - val toBeCheckpointIds = new HashSet[Long] with SynchronizedSet[Long] ++= checkpointIds + val toBeCleanedRDDIds = new HashSet[Int] ++= rddIds --- End diff -- Can this just be `= HashSet(rddIds)` and similarly for the next 4? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user wilson8 commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55634450 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -586,10 +586,12 @@ class CleanerTester( } private def isAllCleanedUp = -toBeCleanedRDDIds.isEmpty && -toBeCleanedShuffleIds.isEmpty && -toBeCleanedBroadcstIds.isEmpty && -toBeCheckpointIds.isEmpty +synchronized { --- End diff -- @srowen Fixed. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11580#discussion_r55400287 --- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala --- @@ -586,10 +586,12 @@ class CleanerTester( } private def isAllCleanedUp = -toBeCleanedRDDIds.isEmpty && -toBeCleanedShuffleIds.isEmpty && -toBeCleanedBroadcstIds.isEmpty && -toBeCheckpointIds.isEmpty +synchronized { --- End diff -- This isn't synchronizing access to these sets on the same lock. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11580#issuecomment-193893662 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13746][Tests]stop using deprecated Sync...
GitHub user wilson8 opened a pull request: https://github.com/apache/spark/pull/11580 [SPARK-13746][Tests]stop using deprecated SynchronizedSet trait SynchronizedSet in package mutable is deprecated You can merge this pull request into a Git repository by running: $ git pull https://github.com/wilson8/spark spark-synchronizedset Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11580.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11580 commit c0bcba3e9f4426e240b77f7b706aaa8aa643b7f1 Author: Wilson Wu Date: 2016-03-08T17:53:08Z [SPARK-13746][Tests]stop using deprecated SynchronizedSet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org