[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196110314 Thank you, @rxin ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196101471 Merging in master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196083702 Thank you for your review, @JoshRosen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196061600 This seems fine to me. Arguably we could remove the dependency graph and revolver plugins now that they're AutoPlugins, since I imagine that a lot of people would prefer to just stick them in their global SBT plugins configuration rather than having to configure them on a per-project basis. Since other people might disagree with this, though, I think it's fine to just upgrade them and leave them here for now. Therefore, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-196043144 Hi, @JoshRosen . If it's possible, could you review this PR, too? This supersedes #11661 . This is a build PR, so I think we need more careful review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/11669#discussion_r55935019
--- Diff: project/SparkBuild.scala ---
@@ -241,7 +240,7 @@ object SparkBuild extends PomBuild {
/* Enable shared settings on all projects */
(allProjects ++ optionallyEnabledProjects ++ assemblyProjects ++
Seq(spark, tools))
.foreach(enable(sharedSettings ++ DependencyOverrides.settings ++
- ExcludedDependencies.settings ++ Revolver.settings))
+ ExcludedDependencies.settings))
--- End diff --
Here, too.
https://github.com/spray/sbt-revolver#installation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/11669#discussion_r55934983
--- Diff: project/SparkBuild.scala ---
@@ -144,7 +143,7 @@ object SparkBuild extends PomBuild {
"org.spark-project" %% "genjavadoc-plugin" %
unidocGenjavadocVersion.value cross CrossVersion.full),
scalacOptions <+= target.map(t => "-P:genjavadoc:out=" + (t / "java")))
- lazy val sharedSettings = graphSettings ++ sparkGenjavadocSettings ++
Seq (
+ lazy val sharedSettings = sparkGenjavadocSettings ++ Seq (
--- End diff --
Sure. They are now `auto plugin`. `graphSettings` is removed now.
https://github.com/jrudolph/sbt-dependency-graph#compatibility-notes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11669#discussion_r55934643
--- Diff: project/SparkBuild.scala ---
@@ -144,7 +143,7 @@ object SparkBuild extends PomBuild {
"org.spark-project" %% "genjavadoc-plugin" %
unidocGenjavadocVersion.value cross CrossVersion.full),
scalacOptions <+= target.map(t => "-P:genjavadoc:out=" + (t / "java")))
- lazy val sharedSettings = graphSettings ++ sparkGenjavadocSettings ++
Seq (
+ lazy val sharedSettings = sparkGenjavadocSettings ++ Seq (
--- End diff --
Was removing `graphSettings` on purpose? and the next change below. I
wanted to make sure they weren't accidental.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195887027 Hi, @srowen . I updated the description of this PR and JIRA issue. In short, I could update most plugins except `sbt-assembly`. It show many errors in `streaming-mqtt/test:assembly`, but I cannot handle that until now. I think more experienced person can upgrade `sbt-assembly` someday soon. And, for `sbt-avro`, the current version turns out to be up-to-date. In their homepage, the 1.0 version is announced but it is not released in repository. Thank you again, @srowen . With your guide, this PR became more meaningful. If you have some time, please review this again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195861649 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195861651 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53015/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195861511 **[Test build #53015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53015/consoleFull)** for PR 11669 at commit [`99a6c76`](https://github.com/apache/spark/commit/99a6c76af3fdb4477c6f6033dddccca72f747032). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13834][BUILD] Update sbt and sbt plugin...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11669#issuecomment-195844293 **[Test build #53015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53015/consoleFull)** for PR 11669 at commit [`99a6c76`](https://github.com/apache/spark/commit/99a6c76af3fdb4477c6f6033dddccca72f747032). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
