[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-20 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198296043
  
**[Test build #53526 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53526/consoleFull)**
 for PR 11817 at commit 
[`4076488`](https://github.com/apache/spark/commit/407648873b8926da80ba351ab0eb2f47847e0be4).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198414800
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53539/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198295919
  
**[Test build #53529 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53529/consoleFull)**
 for PR 11817 at commit 
[`0ee7072`](https://github.com/apache/spark/commit/0ee7072c762a05dc59d9d8d238514e434823a2ef).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198296418
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198324139
  
**[Test build #53529 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53529/consoleFull)**
 for PR 11817 at commit 
[`0ee7072`](https://github.com/apache/spark/commit/0ee7072c762a05dc59d9d8d238514e434823a2ef).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class LocalLimit(`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198414797
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198324333
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53529/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198324331
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread viirya 
GitHub user viirya opened a pull request:

https://github.com/apache/spark/pull/11817

[SPARK-13908][SQL] Add a LocalLimit for CollectLimit operator for early 
pushdown

## What changes were proposed in this pull request?
JIRA: https://issues.apache.org/jira/browse/SPARK-13908

Currently we use a `CollectLimit` plan for the limit operator as latest 
operator to collect data. As it has to be the latest plan, we can't pushdown it 
to reduce the data as early as possible. This patch adds an additional 
`LocalLimit` after `CollectLimit` for this issue. As `LocalLimit` already 
supports wholestage codegen, it can also be integrated in the 
`WholeStageCodegen` plan.

The executed plan without this patch:

CollectLimit 5
+- WholeStageCodegen
   :  +- Range 0, 1, 2, 10, [id#0L]

The executed plan with this patch:

CollectLimit 5
+- WholeStageCodegen
   :  +- LocalLimit 5
   : +- Range 0, 1, 2, 10, [id#0L]



## How was this patch tested?

Existing tests.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/viirya/spark-1 improve-collect-limit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11817


commit 33305dfda1d139fea36f46fd9a50dbfe7e923fd2
Author: Liang-Chi Hsieh 
Date:   2016-03-16T07:38:08Z

init import.

commit 407648873b8926da80ba351ab0eb2f47847e0be4
Author: Liang-Chi Hsieh 
Date:   2016-03-18T08:13:43Z

Merge remote-tracking branch 'upstream/master' into improve-collect-limit




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198296422
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53526/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread viirya 
Github user viirya closed the pull request at:

https://github.com/apache/spark/pull/11817


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread viirya 
Github user viirya commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198648163
  
Rethink this issue, I think the issue described in the JIRA should not 
related to pushdown of limit. Because the latest CollectLimit only takes few 
rows (here is only 1 row) from the iterator of data, it should not scan all the 
data. And I didn't see improvement from benchmark, so I close this now.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-19 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198370581
  
**[Test build #53539 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53539/consoleFull)**
 for PR 11817 at commit 
[`2d983c9`](https://github.com/apache/spark/commit/2d983c9cbae4799b456ba1c01f35a9f4d6de96df).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-18 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198259626
  
**[Test build #53526 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53526/consoleFull)**
 for PR 11817 at commit 
[`4076488`](https://github.com/apache/spark/commit/407648873b8926da80ba351ab0eb2f47847e0be4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-13908][SQL] Add a LocalLimit for Collec...

2016-03-18 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11817#issuecomment-198414182
  
**[Test build #53539 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53539/consoleFull)**
 for PR 11817 at commit 
[`2d983c9`](https://github.com/apache/spark/commit/2d983c9cbae4799b456ba1c01f35a9f4d6de96df).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org