[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/11962 [SPARK-14161] [SQL] Native Parsing for DDL Comand Drop Database What changes were proposed in this pull request? Based on the Hive DDL document https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL The syntax of DDL command for Drop Database is ```SQL DROP (DATABASE|SCHEMA) [IF EXISTS] database_name [RESTRICT|CASCADE]; ``` This PR is to provide a native parsing support for `DROP DATABASE`. How was this patch tested? Added a test case `DDLCommandSuite` You can merge this pull request into a Git repository by running: $ git pull https://github.com/gatorsmile/spark parseDropDatabase Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11962.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11962 commit 8f20e5ad4798170154385edcd7a54456ff8c3148 Author: gatorsmile Date: 2016-03-25T18:21:24Z native DDL parsing for Drop Database --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201405785 cc @yhuai @hvanhovell @viirya Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201405643 **[Test build #54199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54199/consoleFull)** for PR 11962 at commit [`8f20e5a`](https://github.com/apache/spark/commit/8f20e5ad4798170154385edcd7a54456ff8c3148). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201557672 **[Test build #54199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54199/consoleFull)** for PR 11962 at commit [`8f20e5a`](https://github.com/apache/spark/commit/8f20e5ad4798170154385edcd7a54456ff8c3148). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class DropDatabase(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201558323 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201558328 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54199/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201564041 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201564989 **[Test build #54231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54231/consoleFull)** for PR 11962 at commit [`8f20e5a`](https://github.com/apache/spark/commit/8f20e5ad4798170154385edcd7a54456ff8c3148). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11962#discussion_r57500173 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -52,6 +52,12 @@ case class CreateDatabase( props: Map[String, String])(sql: String) extends NativeDDLCommand(sql) with Logging +case class DropDatabase( +databaseName: String, +ifExists: Boolean, +restrict: Boolean)(sql: String) --- End diff -- Add doc to explain the semantic of `ifExists` and `restrict`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11962#discussion_r57501700 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -52,6 +52,12 @@ case class CreateDatabase( props: Map[String, String])(sql: String) extends NativeDDLCommand(sql) with Logging +case class DropDatabase( +databaseName: String, +ifExists: Boolean, +restrict: Boolean)(sql: String) --- End diff -- Sure, let me add the comments. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201590288 **[Test build #54233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54233/consoleFull)** for PR 11962 at commit [`dd0d82b`](https://github.com/apache/spark/commit/dd0d82b8a924b4bced85215a23e5975ea577effe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201618929 **[Test build #54231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54231/consoleFull)** for PR 11962 at commit [`8f20e5a`](https://github.com/apache/spark/commit/8f20e5ad4798170154385edcd7a54456ff8c3148). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class DropDatabase(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201619479 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201619484 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54231/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201641520 **[Test build #54233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54233/consoleFull)** for PR 11962 at commit [`dd0d82b`](https://github.com/apache/spark/commit/dd0d82b8a924b4bced85215a23e5975ea577effe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201642142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54233/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201642138 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201658339 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201719688 **[Test build #54256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54256/consoleFull)** for PR 11962 at commit [`598a6b6`](https://github.com/apache/spark/commit/598a6b68a33f35b0b53cfc9fc7db85b8f6abafc1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201734543 **[Test build #54256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54256/consoleFull)** for PR 11962 at commit [`598a6b6`](https://github.com/apache/spark/commit/598a6b68a33f35b0b53cfc9fc7db85b8f6abafc1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201734661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54256/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201734660 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11962#issuecomment-201930088 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14161] [SQL] Native Parsing for DDL Com...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
