[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread dongjoon-hyun 
Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201523593
  
Thank you for quick review. I closed that Jira issue a minute ago.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread dongjoon-hyun 
Github user dongjoon-hyun commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201522515
  
Oh, I see. I will close the JIRA. 
By the way, may I fix that minor Java lint error here with changed title?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread JoshRosen 
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201520626
  
I'm actually wary of this change. There's a number of times where I've 
found redundant returns but have chosen not to remove them because I was afraid 
of future code refactorings or changes accidentally making the implicit return 
no longer take effect. If this isn't strictly necessary, I'd prefer to not do 
this cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/11968#issuecomment-201516673
  
**[Test build #54217 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54217/consoleFull)**
 for PR 11968 at commit 
[`534b202`](https://github.com/apache/spark/commit/534b202e294ea1095f1c940f6c3af91a98d00145).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14167][MINOR] Remove redundant `returns...

2016-03-25 Thread dongjoon-hyun 
GitHub user dongjoon-hyun opened a pull request:

https://github.com/apache/spark/pull/11968

[SPARK-14167][MINOR] Remove redundant `returns` in Scala code.

## What changes were proposed in this pull request?

Spark Scala code takes advantage of `return` statement as a control flow
in many cases, but it does not mean **redundant** `return` statements are 
needed.
This PR tries to remove redundant `return` statement in Scala code.
Also, this fixes newly added java-lint errors(unused-imports, line-lengsth).

## How was this patch tested?

Pass the Jenkins tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dongjoon-hyun/spark SPARK-14167

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/11968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11968


commit 534b202e294ea1095f1c940f6c3af91a98d00145
Author: Dongjoon Hyun 
Date:   2016-03-25T21:21:49Z

[SPARK-14167][MINOR] Remove redundant `returns` in Scala code.

Spark Scala code takes advantage of `return` statement as a control flow
in many cases, but it does not mean redundant `return` statements are 
needed.
This PR tries to remove redundant `return` statement in Scala code.
Also, this fixes newly added java-lint errors(unused-imports, line-lengsth).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org