[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12029


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread andrewor14
Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-203030872
  
Thanks, merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread sarutak
Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202804739
  
@carsonwang Would you also like to fix another issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202795443
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54419/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202795438
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202794858
  
**[Test build #54419 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54419/consoleFull)**
 for PR 12029 at commit 
[`be4aaa6`](https://github.com/apache/spark/commit/be4aaa667c4e252fdd30490428a29efb59292320).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread carsonwang
Github user carsonwang commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202772769
  
Just noticed another minor issue in the picture. It seems the container Id 
is too long to fit in the black rectangle. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread carsonwang
Github user carsonwang commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202767219
  
After applying the patch, the event timeline can be showed without 
problems. Picture attached.

![afterpatch](https://cloud.githubusercontent.com/assets/9278199/14101400/cb9b9c62-f5c6-11e5-9022-5d6f580f59e4.jpg)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread sarutak
Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202764197
  
@carsonwang Good catch! Could you paste a pic of after this patch applied?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202747100
  
**[Test build #54419 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54419/consoleFull)**
 for PR 12029 at commit 
[`be4aaa6`](https://github.com/apache/spark/commit/be4aaa667c4e252fdd30490428a29efb59292320).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread carsonwang
Github user carsonwang commented on the pull request:

https://github.com/apache/spark/pull/12029#issuecomment-202746825
  
cc @sarutak 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-14232][WebUI]Fix event timeline display...

2016-03-29 Thread carsonwang
GitHub user carsonwang opened a pull request:

https://github.com/apache/spark/pull/12029

[SPARK-14232][WebUI]Fix event timeline display issue when an executor is 
removed with a multiple line reason.

## What changes were proposed in this pull request?
The event timeline doesn't show on job page if an executor is removed with 
a multiple line reason. This PR replaces all new line characters with spaces.


![timelineerror](https://cloud.githubusercontent.com/assets/9278199/14100211/5fd4cd30-f5be-11e5-9cea-f32651a4cd62.jpg)

## How was this patch tested?
Verified on the Web UI.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/carsonwang/spark eventTimeline

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12029


commit be4aaa667c4e252fdd30490428a29efb59292320
Author: Carson Wang 
Date:   2016-03-29T06:36:56Z

Fix event timeline display issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org