[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204958822 @rxin thank you always for the review :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204839111 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204705307 deep-review this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204693044 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204693045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54769/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204692992 **[Test build #54769 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54769/consoleFull)** for PR 12129 at commit [`3f66767`](https://github.com/apache/spark/commit/3f66767ae711da47068ff537f4cc70626ed274b3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204680252 Two places still referring to tachyon are intentionlly left out for backward compibility reasons: - MiMa excludes: https://github.com/apache/spark/blob/master/project/MimaExcludes.scala - test resources of HistoryServer suites: https://github.com/apache/spark/tree/master/core/src/test/resources/spark-events Also, I've checked there is currently no reference to alluxio. @srowen would you mind taking a look when you have time? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12129#discussion_r58290846
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -283,11 +283,11 @@ private[mesos] trait MesosSchedulerUtils extends
Logging {
* are separated by ':'. The ':' implies equality (for singular values)
and "is one of" for
* multiple values (comma separated). For example:
* {{{
- * parseConstraintString("tachyon:true;zone:us-east-1a,us-east-1b")
+ * parseConstraintString("os:centos7;zone:us-east-1a,us-east-1b")
--- End diff --
The key-value `tachyon:true` has been changed to `os:centos7`, since `os`
is an example constrain which appears in [Mesos official
docs](http://mesos.apache.org/documentation/attributes-resources/).
Also note that the `true` as in `tachyon:true` here is actually treated as
normal texts, so changing it to `os:centos7` doesn't make any difference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
