[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220421234 Looks good. Merging into master 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220333996 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220334004 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58865/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220333710 **[Test build #58865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58865/consoleFull)** for PR 13173 at commit [`925e50a`](https://github.com/apache/spark/commit/925e50a2ec9743328edb7aea9c3c7905c54451ec). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220310498 **[Test build #58865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58865/consoleFull)** for PR 13173 at commit [`925e50a`](https://github.com/apache/spark/commit/925e50a2ec9743328edb7aea9c3c7905c54451ec). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220232881 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220232882 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58845/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220232874 **[Test build #58845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58845/consoleFull)** for PR 13173 at commit [`ca22d71`](https://github.com/apache/spark/commit/ca22d7102537bd7411f37aa957f877802ebd6d17). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220232037 **[Test build #58845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58845/consoleFull)** for PR 13173 at commit [`ca22d71`](https://github.com/apache/spark/commit/ca22d7102537bd7411f37aa957f877802ebd6d17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220231882 Doesn't seem to be a valid MiMA check failure. Actually the tool crashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220231892 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220111689 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220111657 **[Test build #58802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58802/consoleFull)** for PR 13173 at commit [`ca22d71`](https://github.com/apache/spark/commit/ca22d7102537bd7411f37aa957f877802ebd6d17). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220111692 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58802/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220109381 **[Test build #58802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58802/consoleFull)** for PR 13173 at commit [`ca22d71`](https://github.com/apache/spark/commit/ca22d7102537bd7411f37aa957f877802ebd6d17). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13173#discussion_r63751785
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -633,16 +633,16 @@ case class ShowCreateTableCommand(table:
TableIdentifier) extends RunnableComman
}
private def showCreateHiveTable(metadata: CatalogTable): String = {
-def reportUnsupportedError(): Unit = {
- throw new UnsupportedOperationException(
+def reportUnsupportedError(features: Seq[String]): Unit = {
+ throw new AnalysisException(
s"Failed to execute SHOW CREATE TABLE against table
${metadata.identifier.quotedString}, " +
- "because it contains table structure(s) (e.g. skewed columns)
that Spark SQL doesn't " +
- "support yet."
+ "which is created by Hive and uses the following feature(s) that
are not yet supported " +
+ "by Spark SQL:\n" + features.map(" - " + _).mkString("\n")
--- End diff --
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13173#discussion_r63732226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -633,16 +633,16 @@ case class ShowCreateTableCommand(table:
TableIdentifier) extends RunnableComman
}
private def showCreateHiveTable(metadata: CatalogTable): String = {
-def reportUnsupportedError(): Unit = {
- throw new UnsupportedOperationException(
+def reportUnsupportedError(features: Seq[String]): Unit = {
+ throw new AnalysisException(
s"Failed to execute SHOW CREATE TABLE against table
${metadata.identifier.quotedString}, " +
- "because it contains table structure(s) (e.g. skewed columns)
that Spark SQL doesn't " +
- "support yet."
+ "which is created by Hive and uses the following feature(s) that
are not yet supported " +
+ "by Spark SQL:\n" + features.map(" - " + _).mkString("\n")
--- End diff --
It sounds like that we are missing functionalities. Can we update the error
message?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220071924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220071926 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58782/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220071576 **[Test build #58782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58782/consoleFull)** for PR 13173 at commit [`950cbe4`](https://github.com/apache/spark/commit/950cbe436656a60aeab906f72531a6fd3e16b71d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220071500 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58781/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220071487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220071132 **[Test build #58781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58781/consoleFull)** for PR 13173 at commit [`3fb03af`](https://github.com/apache/spark/commit/3fb03af8b5615e55ae058ea6a81ba574a29925d1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220042157 cc @yhuai @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220041691 **[Test build #58781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58781/consoleFull)** for PR 13173 at commit [`3fb03af`](https://github.com/apache/spark/commit/3fb03af8b5615e55ae058ea6a81ba574a29925d1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220043330 **[Test build #58782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58782/consoleFull)** for PR 13173 at commit [`950cbe4`](https://github.com/apache/spark/commit/950cbe436656a60aeab906f72531a6fd3e16b71d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/13173 [SPARK-14346][SQL] Lists unsupported Hive features in SHOW CREATE TABLE output ## What changes were proposed in this pull request? This PR is a follow-up of #13079. It replaces `hasUnsupportedFeatures: Boolean` in `CatalogTable` with `unsupportedFeatures: Seq[String]`, which contains unsupported Hive features of the underlying Hive table. In this way, we can accurately report all unsupported Hive features in the exception message. ## How was this patch tested? Updated existing test case to check exception message. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark spark-14346-follow-up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/13173.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13173 commit 3fb03af8b5615e55ae058ea6a81ba574a29925d1 Author: Cheng Lian Date: 2016-05-18T14:13:30Z Lists unsupported Hive features in SHOW CREATE TABLE output --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
