[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[srowen]

Github user srowen closed the pull request at:

https://github.com/apache/spark/pull/12165


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-213341364
  
Yeah I'll close the PR, it was just a WIP anyway. While I disagree with the 
veto (see dev@ thread), I can't stop someone from doing that. I disagree that 
there is "far from consensus", which is the essence of the problem here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[jodersky]

Github user jodersky commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-213328740
  
@srowen, @rxin considering the discussions around the matter, should this 
pr be closed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205791222
  
Yes.

On Tuesday, April 5, 2016, Sean Owen  wrote:

> Yeah I put this out since @lresende  was
> going to start it and was putting out my WIP. Let's keep discussion on
> dev@ . I appreciate your position,
> but I am not seeing agreement with it. Are you already just vetoing?
>
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
> 
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205669913
  
Yeah I put this out since @lresende was going to start it and was putting 
out my WIP. Let's keep discussion on dev@. I appreciate your position, but I am 
not seeing agreement with it. Are you already just vetoing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205652029
  
Hey Sean - not sure if you saw the dev list email I sent. After thinking 
about it a lot more, I am not sure if we want to do this. It's a pretty big 
impediment to people upgrading, and way more aggressive than what we did with 
Java 6.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205589934
  
**[Test build #54922 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54922/consoleFull)**
 for PR 12165 at commit 
[`1173488`](https://github.com/apache/spark/commit/117348827d223822cb70864ebada0594d5edd8ad).
 * This patch **fails build dependency tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205589952
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54922/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205589949
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12165#issuecomment-205588163
  
**[Test build #54922 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54922/consoleFull)**
 for PR 12165 at commit 
[`1173488`](https://github.com/apache/spark/commit/117348827d223822cb70864ebada0594d5edd8ad).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14347] [WIP] Require Java 8 for Spark 2...

[srowen]

GitHub user srowen opened a pull request:

https://github.com/apache/spark/pull/12165

[SPARK-14347] [WIP] Require Java 8 for Spark 2.x

(Just a WIP for now)

## What changes were proposed in this pull request?

- Require Java 8
- Remove MaxPermSize settings
- Move Java 8 tests into main modules
- Update references to Java 8 in docs
- ... more still needs to be done

## How was this patch tested?

Jenkins tests


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srowen/spark SPARK-14347

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12165


commit 117348827d223822cb70864ebada0594d5edd8ad
Author: Sean Owen 
Date:   2016-04-05T01:41:31Z

First pass at changes needed if Java 8 is required




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org