[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-212575056 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56384/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-212575053 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-212574787 **[Test build #56384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56384/consoleFull)** for PR 12252 at commit [`b151065`](https://github.com/apache/spark/commit/b151065aee306b58a3a5400b473210186e1ccaac). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-212544053 **[Test build #56384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56384/consoleFull)** for PR 12252 at commit [`b151065`](https://github.com/apache/spark/commit/b151065aee306b58a3a5400b473210186e1ccaac). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210288804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210288807 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55891/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210288710 **[Test build #55891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55891/consoleFull)** for PR 12252 at commit [`675700f`](https://github.com/apache/spark/commit/675700fff3f07fe5c4dd3e8caeeda82788c12d74). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210280296 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55889/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210280292 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210279874 **[Test build #55889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55889/consoleFull)** for PR 12252 at commit [`715777a`](https://github.com/apache/spark/commit/715777adff9250014e2d42f670765476ae612d74). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210272093 **[Test build #55891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55891/consoleFull)** for PR 12252 at commit [`675700f`](https://github.com/apache/spark/commit/675700fff3f07fe5c4dd3e8caeeda82788c12d74). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12252#discussion_r59824077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -246,13 +247,23 @@ object JdbcUtils extends Logging {
}
/**
+ * The utility to add quote to the column name based on its dialect
+ * @param dialect the JDBC dialect
+ * @param columnName the input column name
+ * @return the quoted column name
+ */
+ private def quoteColumnName(dialect: JdbcDialect, columnName: String):
String = {
+dialect.quoteIdentifier(columnName)
+ }
+
+ /**
* Compute the schema string for this RDD.
*/
- def schemaString(df: DataFrame, url: String): String = {
+ def schemaString(dialect: JdbcDialect, df: DataFrame, url: String):
String = {
val sb = new StringBuilder()
val dialect = JdbcDialects.get(url)
--- End diff --
Thanks for pointing out. I've modified the codes. Please check it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12252#discussion_r59823299
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -246,13 +247,23 @@ object JdbcUtils extends Logging {
}
/**
+ * The utility to add quote to the column name based on its dialect
+ * @param dialect the JDBC dialect
+ * @param columnName the input column name
+ * @return the quoted column name
+ */
+ private def quoteColumnName(dialect: JdbcDialect, columnName: String):
String = {
+dialect.quoteIdentifier(columnName)
+ }
+
+ /**
* Compute the schema string for this RDD.
*/
- def schemaString(df: DataFrame, url: String): String = {
+ def schemaString(dialect: JdbcDialect, df: DataFrame, url: String):
String = {
val sb = new StringBuilder()
val dialect = JdbcDialects.get(url)
--- End diff --
You pass in a parameter named dialect to the schemaString method, but
there's also the dialect that comes from JdbcDialects.get(url) --- that's the
duplicate I was trying to point out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210263822 **[Test build #55889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55889/consoleFull)** for PR 12252 at commit [`715777a`](https://github.com/apache/spark/commit/715777adff9250014e2d42f670765476ae612d74). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12252#discussion_r59819746
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -246,13 +247,23 @@ object JdbcUtils extends Logging {
}
/**
+ * The utility to add quote to the column name based on its dialect
+ * @param dialect the JDBC dialect
+ * @param columnName the input column name
+ * @return the quoted column name
+ */
+ private def quoteColumnName(dialect: JdbcDialect, columnName: String):
String = {
+dialect.quoteIdentifier(columnName)
+ }
+
+ /**
* Compute the schema string for this RDD.
*/
- def schemaString(df: DataFrame, url: String): String = {
+ def schemaString(dialect: JdbcDialect, df: DataFrame, url: String):
String = {
val sb = new StringBuilder()
val dialect = JdbcDialects.get(url)
--- End diff --
The purpose to pass in dialect is to get proper quote for columns based on
its data source. Any suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12252#discussion_r59813944
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
@@ -246,13 +247,23 @@ object JdbcUtils extends Logging {
}
/**
+ * The utility to add quote to the column name based on its dialect
+ * @param dialect the JDBC dialect
+ * @param columnName the input column name
+ * @return the quoted column name
+ */
+ private def quoteColumnName(dialect: JdbcDialect, columnName: String):
String = {
+dialect.quoteIdentifier(columnName)
+ }
+
+ /**
* Compute the schema string for this RDD.
*/
- def schemaString(df: DataFrame, url: String): String = {
+ def schemaString(dialect: JdbcDialect, df: DataFrame, url: String):
String = {
val sb = new StringBuilder()
val dialect = JdbcDialects.get(url)
--- End diff --
Is the new dialect you're passing in different from this one in some way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210203268 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55854/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210203264 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210202790 **[Test build #55854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55854/consoleFull)** for PR 12252 at commit [`b70f21f`](https://github.com/apache/spark/commit/b70f21f91791f1eeb0dee15cc6f95c477f508828). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210178423 **[Test build #55854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55854/consoleFull)** for PR 12252 at commit [`b70f21f`](https://github.com/apache/spark/commit/b70f21f91791f1eeb0dee15cc6f95c477f508828). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210175764 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55851/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210175753 **[Test build #55851 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55851/consoleFull)** for PR 12252 at commit [`ecd52bf`](https://github.com/apache/spark/commit/ecd52bfde3ce752a7280d09a895111faa895c6be). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210175760 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-210175389 **[Test build #55851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55851/consoleFull)** for PR 12252 at commit [`ecd52bf`](https://github.com/apache/spark/commit/ecd52bfde3ce752a7280d09a895111faa895c6be). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-208464762 @andrewor14 Could you please review my codes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207287014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55328/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207287010 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207286378 **[Test build #55328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55328/consoleFull)** for PR 12252 at commit [`9ffb462`](https://github.com/apache/spark/commit/9ffb4621904f2bdaad8e1f4d2403ca01ff7dbd98). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207277190 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55330/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207277124 **[Test build #55330 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55330/consoleFull)** for PR 12252 at commit [`d0c86ea`](https://github.com/apache/spark/commit/d0c86eaa46368e90697ae9cf2e8b3f65adcfef41). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207277183 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207241980 **[Test build #55330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55330/consoleFull)** for PR 12252 at commit [`d0c86ea`](https://github.com/apache/spark/commit/d0c86eaa46368e90697ae9cf2e8b3f65adcfef41). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207239513 **[Test build #55328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55328/consoleFull)** for PR 12252 at commit [`9ffb462`](https://github.com/apache/spark/commit/9ffb4621904f2bdaad8e1f4d2403ca01ff7dbd98). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207217951 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207217952 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55309/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207217742 **[Test build #55309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55309/consoleFull)** for PR 12252 at commit [`88935c5`](https://github.com/apache/spark/commit/88935c5b0eb371476c4f27be26454449fb072e7f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207204035 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55312/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207204023 **[Test build #55312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55312/consoleFull)** for PR 12252 at commit [`51b7f86`](https://github.com/apache/spark/commit/51b7f8615aed79f60176ae08430c98c9b35c91bf). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207204030 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207203761 **[Test build #55312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55312/consoleFull)** for PR 12252 at commit [`51b7f86`](https://github.com/apache/spark/commit/51b7f8615aed79f60176ae08430c98c9b35c91bf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12252#issuecomment-207197063 **[Test build #55309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55309/consoleFull)** for PR 12252 at commit [`88935c5`](https://github.com/apache/spark/commit/88935c5b0eb371476c4f27be26454449fb072e7f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14460] [SQL] properly handling of colum...
GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/12252 [SPARK-14460] [SQL] properly handling of column name contains space ## What changes were proposed in this pull request? Although it is not recommended, table can be created with column name containing space. For example, > create table test.people1 (name TEXT(32) NOT NULL,\`the id\` INTEGER NOT NULL) > When we query the table via JDBC, we also need to escape the column name in the same way if the column name contains space. I've create a method to do the escape, it will only add backtick if column name contains space. ## How was this patch tested? I've updated the test case to test this scenario. Other thought: Is there any other cases we have to escape the column name? Or do we have to always use backtick for each column name? You can merge this pull request into a Git repository by running: $ git pull https://github.com/bomeng/spark SPARK-14460 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12252 commit 88935c5b0eb371476c4f27be26454449fb072e7f Author: bomeng Date: 2016-04-08T03:25:33Z fix issue of column name contains space --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
