[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207887639 Thank you for merging, @rxin . Jenkins seems to have some trouble during merging. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207880334 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207848160 @srowen . Could you merge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207591913 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207591918 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55378/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207591583 **[Test build #55378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55378/consoleFull)** for PR 12242 at commit [`38b9bad`](https://github.com/apache/spark/commit/38b9bada8f8811054953012458365094395ef610). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207549224 Yes, that was just fixed by Josh. (The Apache dist archives are offline) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207549109 **[Test build #55378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55378/consoleFull)** for PR 12242 at commit [`38b9bad`](https://github.com/apache/spark/commit/38b9bada8f8811054953012458365094395ef610). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207548881 By the way, Jenkins fails to find `mvn`. Is there any problem there? ``` Using `mvn` from path: /home/jenkins/workspace/SparkPullRequestBuilder/build/apache-maven-3.3.9/bin/mvn build/mvn: line 156: /home/jenkins/workspace/SparkPullRequestBuilder/build/apache-maven-3.3.9/bin/mvn: No such file or directory Error while getting version string from Maven: ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207548804 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12242#issuecomment-207548499
@srowen . It's moved like the following.
- rename sql/core/src/main/{scala =>
java}/org/apache/spark/sql/execution/BufferedRowIterator.java (100%)
Now, the only 23 `package-info.java` files are under `scala`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12242#discussion_r59069172
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -60,7 +60,7 @@ public long durationMs() {
/**
* Initializes from array of iterators of InternalRow.
*/
- public abstract void init(int index, Iterator iters[]);
+ public abstract void init(int index, Iterator[] iters);
--- End diff --
Oh, I see. There was some misunderstanding between us. :) I thought there
was some reason for the others.
Thank you. I'll fix right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207543935 **[Test build #55374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55374/consoleFull)** for PR 12242 at commit [`dbd9d5a`](https://github.com/apache/spark/commit/dbd9d5ade694921a1636ad5aa326b3a01809029a). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207543950 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55374/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207543944 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12242#discussion_r59067649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -60,7 +60,7 @@ public long durationMs() {
/**
* Initializes from array of iterators of InternalRow.
*/
- public abstract void init(int index, Iterator iters[]);
+ public abstract void init(int index, Iterator[] iters);
--- End diff --
And we want to move this class too, right? sorry I thought that was
implicit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207543761 **[Test build #55374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55374/consoleFull)** for PR 12242 at commit [`dbd9d5a`](https://github.com/apache/spark/commit/dbd9d5ade694921a1636ad5aa326b3a01809029a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12242#issuecomment-207543531
Thank you, @srowen , @davies , @rxin . I moved those files.
- rename core/src/main/{scala =>
java}/org/apache/spark/io/LZ4BlockInputStream.java (100%)
- rename sql/core/src/main/{scala =>
java}/org/apache/spark/sql/expressions/java/typed.java (100%)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12242#discussion_r59053571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/java/typed.java ---
@@ -28,7 +27,7 @@
/**
* :: Experimental ::
- * Type-safe functions available for {@link Dataset} operations in Java.
--- End diff --
we can move it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12242#discussion_r59048192
--- Diff: core/src/main/scala/org/apache/spark/io/LZ4BlockInputStream.java
---
@@ -90,12 +87,13 @@ public LZ4BlockInputStream(InputStream in,
LZ4FastDecompressor decompressor, Che
}
/**
- * Create a new instance using {@link XXHash32} for checksuming.
+ * Create a new instance using {@link net.jpountz.xxhash.XXHash32} for
checksuming.
* @see #LZ4BlockInputStream(InputStream, LZ4FastDecompressor, Checksum)
- * @see StreamingXXHash32#asChecksum()
+ * @see net.jpountz.xxhash.StreamingXXHash32#asChecksum()
*/
public LZ4BlockInputStream(InputStream in, LZ4FastDecompressor
decompressor) {
--- End diff --
No reason, please fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12242#discussion_r59014353
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/java/typed.java ---
@@ -28,7 +27,7 @@
/**
* :: Experimental ::
- * Type-safe functions available for {@link Dataset} operations in Java.
--- End diff --
@rxin same question, do you know why this wasn't under the java root?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12242#discussion_r59014215
--- Diff: core/src/main/scala/org/apache/spark/io/LZ4BlockInputStream.java
---
@@ -90,12 +87,13 @@ public LZ4BlockInputStream(InputStream in,
LZ4FastDecompressor decompressor, Che
}
/**
- * Create a new instance using {@link XXHash32} for checksuming.
+ * Create a new instance using {@link net.jpountz.xxhash.XXHash32} for
checksuming.
* @see #LZ4BlockInputStream(InputStream, LZ4FastDecompressor, Checksum)
- * @see StreamingXXHash32#asChecksum()
+ * @see net.jpountz.xxhash.StreamingXXHash32#asChecksum()
*/
public LZ4BlockInputStream(InputStream in, LZ4FastDecompressor
decompressor) {
--- End diff --
@davies do you know why this .java file is in the scala source root? we
could fix that as part of this PR if it's just an oversight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207217696 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207217697 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55303/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207217492 **[Test build #55303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55303/consoleFull)** for PR 12242 at commit [`832b801`](https://github.com/apache/spark/commit/832b8014df9b0f23c5a52ff559a9dd249cb33cfa). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207191987 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55256/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207191985 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207191161 **[Test build #55303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55303/consoleFull)** for PR 12242 at commit [`832b801`](https://github.com/apache/spark/commit/832b8014df9b0f23c5a52ff559a9dd249cb33cfa). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207188874 **[Test build #55256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55256/consoleFull)** for PR 12242 at commit [`582177d`](https://github.com/apache/spark/commit/582177d02683359c65716f6dd919178bbab5fa03). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207124212 **[Test build #55256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55256/consoleFull)** for PR 12242 at commit [`582177d`](https://github.com/apache/spark/commit/582177d02683359c65716f6dd919178bbab5fa03). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207123707 The following is the failure message. It seems o be irrelevant. I'll rebase this to trigger again. ``` [error] Test org.apache.spark.launcher.LauncherServerSuite.testCommunication failed: java.lang.AssertionError: null, took 0.008 sec [error] at org.apache.spark.launcher.LauncherServerSuite.testCommunication(LauncherServerSuite.java:89) [error] ... [info] Test run finished: 1 failed, 0 ignored, 3 total, 0.141s ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207113780 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55243/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207113776 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207113612 **[Test build #55243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55243/consoleFull)** for PR 12242 at commit [`aaf19f9`](https://github.com/apache/spark/commit/aaf19f976632b1b0b9e40c0dd33d6b556504b48d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207085112 Yes. It's strange for me, too. We may change the paths, but there is one understandable example: `package-info.java`. (It's not related to this PR, but I found 10 `package-info.java`, too.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207081489 Huh, why do we have .java files under the scala root? I can't think of a good reason off the top of my head. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12242#issuecomment-207080059 **[Test build #55243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55243/consoleFull)** for PR 12242 at commit [`aaf19f9`](https://github.com/apache/spark/commit/aaf19f976632b1b0b9e40c0dd33d6b556504b48d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14465][BUILD] Checkstyle should check a...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12242
[SPARK-14465][BUILD] Checkstyle should check all Java files
## What changes were proposed in this pull request?
Currently, `checkstyle` is configured to check the files under
`src/main/java`. However, Spark has Java files in `src/main/scala`, too. This
PR fixes the following configuration in `pom.xml` and the unchecked-so-far
violations on those files.
```xml
-${basedir}/src/main/java
+${basedir}/src/main/java,${basedir}/src/main/scala
```
## How was this patch tested?
After passing the Jenkins build and manually `dev/lint-java`. (Note that
Jenkins does not run `lint-java`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-14465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12242
commit aaf19f976632b1b0b9e40c0dd33d6b556504b48d
Author: Dongjoon Hyun
Date: 2016-04-07T20:29:52Z
[SPARK-14465][BUILD] Checkstyle should check all Java files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
