[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-219168440 @clockfly It seems that this does not work with temporary tables, could you send an PR to fix that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12947 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218361168 Thanks - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218359085 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218359086 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58318/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218358970 **[Test build #58318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58318/consoleFull)** for PR 12947 at commit [`59f816f`](https://github.com/apache/spark/commit/59f816f4cf91979282d3b9385d746099b040fbc1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user clockfly commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218351169 @davies, Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218350411 **[Test build #58318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58318/consoleFull)** for PR 12947 at commit [`59f816f`](https://github.com/apache/spark/commit/59f816f4cf91979282d3b9385d746099b040fbc1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218284707 Could you also update the screen shot in PR description? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12947#discussion_r62748015
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -127,8 +129,13 @@ private[sql] case class RDDScanExec(
private[sql] trait DataSourceScanExec extends LeafExecNode {
val rdd: RDD[InternalRow]
val relation: BaseRelation
+ val metastoreTableIdentifier: Option[TableIdentifier]
- override val nodeName: String = relation.toString
+ override val nodeName: String = if (metastoreTableIdentifier.isEmpty) {
+"Scan " + relation.toString
+ } else {
+"Scan " + relation.toString + " " +
metastoreTableIdentifier.get.unquotedString
--- End diff --
s"Scan $relation
${metastoreTableIdentifier.map(_.unquotedString).getOrElse("")}".trim
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12947#discussion_r62746872
--- Diff:
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.css
---
@@ -41,3 +41,8 @@
stroke: #444;
stroke-width: 1.5px;
}
+
+/* Breaks the long string like file path when showing tooltips */
+.tooltip-inner {
+ word-wrap:break-word;
+}
--- End diff --
Add a newline here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218265509 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218265515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58250/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218265197 **[Test build #58250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58250/consoleFull)** for PR 12947 at commit [`b3e9775`](https://github.com/apache/spark/commit/b3e977514dfefa0105ffdaa83bf382250d132a5a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218243022 **[Test build #58250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58250/consoleFull)** for PR 12947 at commit [`b3e9775`](https://github.com/apache/spark/commit/b3e977514dfefa0105ffdaa83bf382250d132a5a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user clockfly commented on the pull request:
https://github.com/apache/spark/pull/12947#issuecomment-218241829
For load:
```
scala> spark.read.format("json").load("/home/xzhong10/people.json")
res5: org.apache.spark.sql.DataFrame = [age: bigint, name: string]
scala> res5.explain()
== Physical Plan ==
WholeStageCodegen
: +- Scan json[age#20L,name#21] Format: JSON, InputPaths:
file:/home/xzhong10/people.json, PushedFilters: [], ReadSchema:
struct
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user clockfly commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-21892 Something like "Scan parquet" , but without table name suffix. I will show you an example. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218220895 How does it look like when there is no table but just files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218124851 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58229/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218124849 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218124658 **[Test build #58229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58229/consoleFull)** for PR 12947 at commit [`f0a0951`](https://github.com/apache/spark/commit/f0a0951a3b74ff157024559b49460a4aba6339c3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user clockfly commented on the pull request:
https://github.com/apache/spark/pull/12947#issuecomment-218115976
How is the new UI?
And for explain:
```
scala> spark.sql("select * from jt4").explain()
== Physical Plan ==
WholeStageCodegen
: +- BatchedScan Scan parquet default.jt4[id#0L] Format: ParquetFormat,
InputPaths:
file:/home/xzhong10/aa//ccc/d//ff//hh...,
PushedFilters: [], ReadSchema: struct
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218107710 **[Test build #58229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58229/consoleFull)** for PR 12947 at commit [`f0a0951`](https://github.com/apache/spark/commit/f0a0951a3b74ff157024559b49460a4aba6339c3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049881 "HadoopFiles" isn't very useful, and sometimes the files are not even in Hadoop (e.g. it is just using Hadoop APIs to read S3). Can we say "scan" instead, and say the name of the data source? e.g. "parquet scan default.jt4" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049358 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049359 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58195/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218049248 **[Test build #58195 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58195/consoleFull)** for PR 12947 at commit [`b6b38a7`](https://github.com/apache/spark/commit/b6b38a7507414f6fea7edc0b6544b03f91573dd3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user clockfly commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218040784 @yhuai Thanks for the reminder, the css has been updated for the long tooltip.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12947#issuecomment-218039859 **[Test build #58195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58195/consoleFull)** for PR 12947 at commit [`b6b38a7`](https://github.com/apache/spark/commit/b6b38a7507414f6fea7edc0b6544b03f91573dd3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14476][SQL] Improve the physical plan v...
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12947#discussion_r62420950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -224,7 +236,9 @@ private[sql] case class BatchedDataSourceScanExec(
}
override def simpleString: String = {
-val metadataEntries = for ((key, value) <- metadata.toSeq.sorted)
yield s"$key: $value"
+val metadataEntries = for ((key, value) <- metadata.toSeq.sorted)
yield {
+ key + ": " + StringUtils.abbreviate(value, 100)
--- End diff --
Can you play with some long paths and see if 100 is good value (it will be
also good to put screenshot in the PR description)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
