[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12300


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208720757
  
Thanks. Merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208717455
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208717457
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55585/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208717307
  
**[Test build #55585 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55585/consoleFull)**
 for PR 12300 at commit 
[`ca2a94b`](https://github.com/apache/spark/commit/ca2a94b749e613d7eb5e50b129bf66a30530362d).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208716501
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208694952
  
**[Test build #55585 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55585/consoleFull)**
 for PR 12300 at commit 
[`ca2a94b`](https://github.com/apache/spark/commit/ca2a94b749e613d7eb5e50b129bf66a30530362d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[cloud-fan]

Github user cloud-fan commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208694863
  
np, I already fixed it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208693757
  
Ah. sorry. Maybe the commit I just made caused the conflicts...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208681640
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55564/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208681637
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208681486
  
**[Test build #55564 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55564/consoleFull)**
 for PR 12300 at commit 
[`35462d2`](https://github.com/apache/spark/commit/35462d234db8af612c176d40d5348dc6c71ee37d).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208652842
  
**[Test build #55564 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55564/consoleFull)**
 for PR 12300 at commit 
[`35462d2`](https://github.com/apache/spark/commit/35462d234db8af612c176d40d5348dc6c71ee37d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208625180
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208625182
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/1/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208625178
  
**[Test build #1 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1/consoleFull)**
 for PR 12300 at commit 
[`35682a8`](https://github.com/apache/spark/commit/35682a84e57fbeb1900b0c2c0b6e6a559878c8dd).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208623928
  
**[Test build #1 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1/consoleFull)**
 for PR 12300 at commit 
[`35682a8`](https://github.com/apache/spark/commit/35682a84e57fbeb1900b0c2c0b6e6a559878c8dd).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208411048
  
And the ORC data source, which lives in the `sql/hive`, hasn't been cleaned 
yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208410251
  
We can also remove [these pattern match guard conditions][1] and the 
`spark.sql.sources.fileScan` SQL option.

[1]: 
https://github.com/apache/spark/blob/e82d95bf63f57cefa02dc545ceb451ecdeedce28/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala#L59-L66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208375638
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208375643
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55523/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208375628
  
**[Test build #55523 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55523/consoleFull)**
 for PR 12300 at commit 
[`6c9ede0`](https://github.com/apache/spark/commit/6c9ede099fcfac1e40596a43d36d462d6ecd256d).
 * This patch **fails to build**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208373448
  
**[Test build #55523 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55523/consoleFull)**
 for PR 12300 at commit 
[`6c9ede0`](https://github.com/apache/spark/commit/6c9ede099fcfac1e40596a43d36d462d6ecd256d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[cloud-fan]

Github user cloud-fan commented on the pull request:

https://github.com/apache/spark/pull/12300#issuecomment-208371982
  
CC @marmbrus @liancheng @yhuai 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14535][SQL] Remove buildInternalScan fr...

[cloud-fan]

GitHub user cloud-fan opened a pull request:

https://github.com/apache/spark/pull/12300

[SPARK-14535][SQL] Remove buildInternalScan from FileFormat

## What changes were proposed in this pull request?

Now `HadoopFsRelation` with all kinds of file formats can be handled in 
`FileSourceStrategy`, we can remove the branches for  `HadoopFsRelation` in 
`FileSourceStrategy` and the `buildInternalScan` API from `FileFormat`.


## How was this patch tested?

existing tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloud-fan/spark remove

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12300


commit 6c9ede099fcfac1e40596a43d36d462d6ecd256d
Author: Wenchen Fan 
Date:   2016-04-11T14:16:18Z

Remove buildInternalScan from FileFormat




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org