[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12336


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209832139
  
Looks like a clean improvement; merged to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[holdenk]

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209559464
  
If this looks OK to people it would be good to merge before anymore PyDoc 
highlighting inconsistencies make it into master. Maybe @JoshRosen or @davies 
could merge could also take a quick look and merge this if its ok as they are 
the most recent committers on the Makefile?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209419242
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[BryanCutler]

Github user BryanCutler commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209238027
  
`?=` seems to do the trick, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209189333
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55669/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209189330
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209188744
  
**[Test build #55669 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55669/consoleFull)**
 for PR 12336 at commit 
[`d4f9687`](https://github.com/apache/spark/commit/d4f9687e5f17dd7e76ba3b5ccf1f25c56f5aadd2).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209163487
  
**[Test build #55669 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55669/consoleFull)**
 for PR 12336 at commit 
[`d4f9687`](https://github.com/apache/spark/commit/d4f9687e5f17dd7e76ba3b5ccf1f25c56f5aadd2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209126053
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209126016
  
**[Test build #55652 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55652/consoleFull)**
 for PR 12336 at commit 
[`3b85ed0`](https://github.com/apache/spark/commit/3b85ed0173b037ffd7fbb7c58b4190a7529336ca).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209126055
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55652/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209120398
  
**[Test build #55652 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55652/consoleFull)**
 for PR 12336 at commit 
[`3b85ed0`](https://github.com/apache/spark/commit/3b85ed0173b037ffd7fbb7c58b4190a7529336ca).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209115424
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209115382
  
**[Test build #55648 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55648/consoleFull)**
 for PR 12336 at commit 
[`3f19309`](https://github.com/apache/spark/commit/3f1930917c9535e027b5882db542a0a285ddf5d5).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209115429
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55648/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209109784
  
**[Test build #55648 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55648/consoleFull)**
 for PR 12336 at commit 
[`3f19309`](https://github.com/apache/spark/commit/3f1930917c9535e027b5882db542a0a285ddf5d5).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[holdenk]

Github user holdenk commented on the pull request:

https://github.com/apache/spark/pull/12336#issuecomment-209108484
  
cc @BryanCutler who ran into this issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefi...

[holdenk]

GitHub user holdenk opened a pull request:

https://github.com/apache/spark/pull/12336

[SPARK-14573][PYSPARK][BUILD] Fix PyDoc Makefile & highlighting issues

## What changes were proposed in this pull request?

The PyDoc Makefile used "=" rather than "?=" for setting env variables so 
it overwrote the user values. This ignored the environment variables we set for 
linting allowing warnings through. This PR also fixes the warnings that had 
been introduced.


## How was this patch tested?

manual local export & make

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/holdenk/spark SPARK-14573-fix-pydoc-makefile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12336


commit c40c50a7ccfb940ef01f2ffd23fd698dd797d4ea
Author: Holden Karau 
Date:   2016-04-12T20:27:42Z

Fix the Makefile

commit d5b148d0999c73d269b046f7a8b50571ccb05943
Author: Holden Karau 
Date:   2016-04-12T20:33:28Z

Fix __all__ list in ml/regression.py

commit 3f1930917c9535e027b5882db542a0a285ddf5d5
Author: Holden Karau 
Date:   2016-04-12T21:16:53Z

Fix hightlighting issues in context.py




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org