[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user lresende closed the pull request at: https://github.com/apache/spark/pull/12349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209412203 Yeah it's redundant and I think it's just another thing to not get filled out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209266678 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55689/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209266674 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209265926 **[Test build #55689 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55689/consoleFull)** for PR 12349 at commit [`9a8b509`](https://github.com/apache/spark/commit/9a8b509d66d0f0c9f9fd2075f6023975fc7ea1fe). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209232165 btw https://spark-prs.appspot.com/ already does this for you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209232172 **[Test build #55689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55689/consoleFull)** for PR 12349 at commit [`9a8b509`](https://github.com/apache/spark/commit/9a8b509d66d0f0c9f9fd2075f6023975fc7ea1fe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209229451 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209229455 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55682/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209229345 **[Test build #55682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55682/consoleFull)** for PR 12349 at commit [`d927d13`](https://github.com/apache/spark/commit/d927d13e6d99e36828d980f091e462c707f76986). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user lresende commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209225537 ok, I will leave it open for a day in case anyone else has interest on the change, otherwise close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209222504 I'm not sure if we want this. People are already complaining the template is too long. This creates more work to create a pr, and does not add any extra information. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user lresende commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209221983 @rxin It is, but you then have to search for the jira. This makes it much more easy to just access the jira, from the link, similar to how the jira has the link to the pr. I have seen this in different projects, and found it very convenient and useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209217502 Isn't this obvious from the JIRA title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12349#issuecomment-209212144 **[Test build #55682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55682/consoleFull)** for PR 12349 at commit [`d927d13`](https://github.com/apache/spark/commit/d927d13e6d99e36828d980f091e462c707f76986). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14590] Update pull request template wit...
GitHub user lresende opened a pull request: https://github.com/apache/spark/pull/12349 [SPARK-14590] Update pull request template with JIRA link ## What changes were proposed in this pull request? Update pull request template to have direct link to jira issue You can merge this pull request into a Git repository by running: $ git pull https://github.com/lresende/spark SPARK-14590 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12349 commit d927d13e6d99e36828d980f091e462c707f76986 Author: Luciano ResendeDate: 2016-04-13T03:27:24Z [SPARK-14590] Update pull request template with JIRA link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org