[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-216300544 Thanks, merging to master and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215948426 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215948427 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57427/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215948384 **[Test build #57427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57427/consoleFull)** for PR 12399 at commit [`adc3158`](https://github.com/apache/spark/commit/adc3158d2a7339dfe95bf012bfbc047892e9a728). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215944898 **[Test build #57427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57427/consoleFull)** for PR 12399 at commit [`adc3158`](https://github.com/apache/spark/commit/adc3158d2a7339dfe95bf012bfbc047892e9a728). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215944743 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215942539 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57410/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215942514 **[Test build #57410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57410/consoleFull)** for PR 12399 at commit [`adc3158`](https://github.com/apache/spark/commit/adc3158d2a7339dfe95bf012bfbc047892e9a728). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215942537 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215940178 **[Test build #57410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57410/consoleFull)** for PR 12399 at commit [`adc3158`](https://github.com/apache/spark/commit/adc3158d2a7339dfe95bf012bfbc047892e9a728). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215940097 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215939852 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57408/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215939851 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215939829 **[Test build #57408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57408/consoleFull)** for PR 12399 at commit [`adc3158`](https://github.com/apache/spark/commit/adc3158d2a7339dfe95bf012bfbc047892e9a728). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215934261 **[Test build #57408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57408/consoleFull)** for PR 12399 at commit [`adc3158`](https://github.com/apache/spark/commit/adc3158d2a7339dfe95bf012bfbc047892e9a728). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215892595 Sorry this went stale. Do we still want to try and get this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12399#discussion_r60335271
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -130,60 +126,52 @@ case class Invoke(
case _ => None
}
- lazy val unboxer = (dataType,
method.map(_.getReturnType.getName).getOrElse("")) match {
-case (IntegerType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Integer)$s).intValue()"
-case (LongType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Long)$s).longValue()"
-case (FloatType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Float)$s).floatValue()"
-case (ShortType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Short)$s).shortValue()"
-case (ByteType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Byte)$s).byteValue()"
-case (DoubleType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Double)$s).doubleValue()"
-case (BooleanType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Boolean)$s).booleanValue()"
-case _ => identity[String] _
- }
-
override def doGenCode(ctx: CodegenContext, ev: ExprCode): String = {
val javaType = ctx.javaType(dataType)
val obj = targetObject.genCode(ctx)
val argGen = arguments.map(_.genCode(ctx))
val argString = argGen.map(_.value).mkString(", ")
-// If the function can return null, we do an extra check to make sure
our null bit is still set
-// correctly.
-val objNullCheck = if (ctx.defaultValue(dataType) == "null") {
- s"boolean ${ev.isNull} = ${ev.value} == null;"
+val callFunc = if (method.isDefined &&
method.get.getReturnType.isPrimitive) {
+ s"${obj.value}.$functionName($argString)"
} else {
- ev.isNull = obj.isNull
- ""
+ s"(${ctx.boxedType(javaType)})
${obj.value}.$functionName($argString)"
}
-val value = unboxer(s"${obj.value}.$functionName($argString)")
--- End diff --
We do, but I simplified it, see the `callFunc` above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12399#discussion_r60267607
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala
---
@@ -130,60 +126,52 @@ case class Invoke(
case _ => None
}
- lazy val unboxer = (dataType,
method.map(_.getReturnType.getName).getOrElse("")) match {
-case (IntegerType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Integer)$s).intValue()"
-case (LongType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Long)$s).longValue()"
-case (FloatType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Float)$s).floatValue()"
-case (ShortType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Short)$s).shortValue()"
-case (ByteType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Byte)$s).byteValue()"
-case (DoubleType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Double)$s).doubleValue()"
-case (BooleanType, "java.lang.Object") => (s: String) =>
- s"((java.lang.Boolean)$s).booleanValue()"
-case _ => identity[String] _
- }
-
override def doGenCode(ctx: CodegenContext, ev: ExprCode): String = {
val javaType = ctx.javaType(dataType)
val obj = targetObject.genCode(ctx)
val argGen = arguments.map(_.genCode(ctx))
val argString = argGen.map(_.value).mkString(", ")
-// If the function can return null, we do an extra check to make sure
our null bit is still set
-// correctly.
-val objNullCheck = if (ctx.defaultValue(dataType) == "null") {
- s"boolean ${ev.isNull} = ${ev.value} == null;"
+val callFunc = if (method.isDefined &&
method.get.getReturnType.isPrimitive) {
+ s"${obj.value}.$functionName($argString)"
} else {
- ev.isNull = obj.isNull
- ""
+ s"(${ctx.boxedType(javaType)})
${obj.value}.$functionName($argString)"
}
-val value = unboxer(s"${obj.value}.$functionName($argString)")
--- End diff --
Don't we need to do unboxing anymore here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211699140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56164/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211699139 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211698745 **[Test build #56164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56164/consoleFull)** for PR 12399 at commit [`db476f5`](https://github.com/apache/spark/commit/db476f51b040e585ab95a8298a260b74e8e37651). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211659729 **[Test build #56164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56164/consoleFull)** for PR 12399 at commit [`db476f5`](https://github.com/apache/spark/commit/db476f51b040e585ab95a8298a260b74e8e37651). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210102541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55825/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210102537 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210102167 **[Test build #55825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55825/consoleFull)** for PR 12399 at commit [`43644ef`](https://github.com/apache/spark/commit/43644ef9e8cb04ac230d04089505b8c5bf2053eb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210054980 **[Test build #55825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55825/consoleFull)** for PR 12399 at commit [`43644ef`](https://github.com/apache/spark/commit/43644ef9e8cb04ac230d04089505b8c5bf2053eb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210053519 cc @marmbrus @yhuai @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/12399 [SPARK-14637][SQL] object expressions cleanup ## What changes were proposed in this pull request? Simplify and clean up some object expressions: 1. simplify the logic to handle `propagateNull` 2. add `propagateNull` parameter to `Invoke` 3. simplify the unbox logic in `Invoke` 4. other minor cleanup ## How was this patch tested? existing tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark object Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12399.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12399 commit 43644ef9e8cb04ac230d04089505b8c5bf2053eb Author: Wenchen Fan Date: 2016-04-14T17:04:51Z object expressions cleanup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
