[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-56074326 Let's close this issue for now given the comments from me and @rxin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-55783768 I also don't think we should add extra interfaces that we aren't going to use. In Spark we never interact with these components in a generic way, so I don't see any value to having this extra cruft all over the place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/991#discussion_r17510639 --- Diff: core/src/main/scala/org/apache/spark/Service.scala --- @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark + +trait Service extends java.io.Closeable { --- End diff -- @rxin Here has inherited `Closeable` class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-55482578 Hey @witgo I thought about this more, and at this point I'm not sure if it is worth it to standardize this interface. The reason is we have a lot of "services" in Spark, but they have different ways to be initialized (some of them would require having different initialize methods that might not fit into the LifeCycle trait. I'm also worried about the use of mixins with multiple traits having default implementations. In the past that has caused trouble in Java interoperability and binary compatibility. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-55482579 Maybe we should just implement Closeable? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-54081074 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19566/consoleFull) for PR 991 at commit [`79f48dc`](https://github.com/apache/spark/commit/79f48dcff976de99f06057da48951fa16e6d68d8). * This patch **fails** unit tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `trait Lifecycle extends Service ` * `trait Service extends java.io.Closeable ` * `class SparkContext(config: SparkConf) extends Logging with Lifecycle ` * `class JavaStreamingContext(val ssc: StreamingContext) extends Lifecycle ` * `class JobGenerator(jobScheduler: JobScheduler) extends Logging with Lifecycle ` * `class JobScheduler(val ssc: StreamingContext) extends Logging with Lifecycle ` * `class ReceiverTracker(ssc: StreamingContext) extends Logging with Lifecycle ` * ` class ReceiverLauncher extends Lifecycle ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-54077338 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19566/consoleFull) for PR 991 at commit [`79f48dc`](https://github.com/apache/spark/commit/79f48dcff976de99f06057da48951fa16e6d68d8). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-53683774 @witgo I'm going to take a look at this later for 1.2. I think it's a good idea to have a Service abstraction for service that we can start/stop. The current API is slightly more complicated than necessary, but it is in good direction. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-50984173 QA results for PR 991:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):trait Lifecycle extends Service {trait Service extends java.io.Closeable {class SparkContext(config: SparkConf) extends Logging with Lifecycle {class JavaStreamingContext(val ssc: StreamingContext) extends Lifecycle {class JobGenerator(jobScheduler: JobScheduler) extends Logging with Lifecycle {class JobScheduler(val ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverTracker(ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverLauncher extends Lifecycle {For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17806/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-50983352 QA tests have started for PR 991. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17806/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-50983325 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-50983223 QA results for PR 991:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):trait Lifecycle extends Service {trait Service extends java.io.Closeable {class SparkContext(config: SparkConf) extends Logging with Lifecycle {class JavaStreamingContext(val ssc: StreamingContext) extends Lifecycle {class JobGenerator(jobScheduler: JobScheduler) extends Logging with Lifecycle {class JobScheduler(val ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverTracker(ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverLauncher extends Lifecycle {For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17805/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-50982869 QA tests have started for PR 991. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17805/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-50499860 QA tests have started for PR 991. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17361/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-49218315 QA results for PR 991:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):trait Lifecycle extends Service {trait Service extends java.io.Closeable {class SparkContext(config: SparkConf) extends Logging with Lifecycle {class JavaStreamingContext(val ssc: StreamingContext) extends Lifecycle {class JobGenerator(jobScheduler: JobScheduler) extends Logging with Lifecycle {class JobScheduler(val ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverTracker(ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverLauncher extends Lifecycle {For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16741/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-49205438 QA tests have started for PR 991. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16741/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-49074313 QA results for PR 991:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):trait Lifecycle extends Service {trait Service extends java.io.Closeable {class SparkContext(config: SparkConf) extends Logging with Lifecycle {class JavaStreamingContext(val ssc: StreamingContext) extends Lifecycle {class JobGenerator(jobScheduler: JobScheduler) extends Logging with Lifecycle {class JobScheduler(val ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverTracker(ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverLauncher extends Lifecycle {For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16686/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-49063796 QA results for PR 991:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):trait Lifecycle extends Service {class SparkContext(config: SparkConf) extends Logging with Lifecycle {class JavaStreamingContext(val ssc: StreamingContext) extends Lifecycle {class JobGenerator(jobScheduler: JobScheduler) extends Logging with Lifecycle {class JobScheduler(val ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverTracker(ssc: StreamingContext) extends Logging with Lifecycle {class ReceiverLauncher extends Lifecycle {For more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16684/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-49062165 QA tests have started for PR 991. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16686/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-49053374 QA tests have started for PR 991. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16684/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47221923 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16158/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47221922 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47218189 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47218203 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47217893 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47212987 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16157/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47212986 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47210122 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47210112 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47207697 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47207698 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16156/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47207203 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/991#issuecomment-47207182 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/991#discussion_r14232502 --- Diff: core/src/main/java/org/apache/spark/Service.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark; + +import java.io.Closeable; +import java.io.IOException; + +// copy from hadoop +public interface Service extends Closeable { --- End diff -- Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-1477]: Add the lifecycle interface
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/991#discussion_r14229594 --- Diff: core/src/main/java/org/apache/spark/Service.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark; + +import java.io.Closeable; +import java.io.IOException; + +// copy from hadoop +public interface Service extends Closeable { --- End diff -- Java code can actually extend Scala traits as well. Do you have other concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1477: Add the lifecycle interface
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/379#issuecomment-40344734 We are currently a little swamped with Spark 1.0 stuff, we will definitely take a look soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: SPARK-1477: Add the lifecycle interface
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/379#issuecomment-40327489 @andrewor14 ,@tdas , @pwendell ,mind reviewing the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---