[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-213156566 Thank you, @davies ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-213153688 LGTM, Merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-213152900 Hi, @shivaram and @davies . Could you review this PR and give some advice please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212742481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212742482 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56479/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212742410 **[Test build #56479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56479/consoleFull)** for PR 12547 at commit [`0abf874`](https://github.com/apache/spark/commit/0abf874b4b5402197c28b74ba16f50b46c81a1d4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212737812 **[Test build #56479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56479/consoleFull)** for PR 12547 at commit [`0abf874`](https://github.com/apache/spark/commit/0abf874b4b5402197c28b74ba16f50b46c81a1d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12547#discussion_r60524553
--- Diff: R/pkg/R/context.R ---
@@ -225,3 +225,17 @@ broadcast <- function(sc, object) {
setCheckpointDir <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheckpointDir",
suppressWarnings(normalizePath(dirName
}
+
+#' Set new log level
+#'
+#' Set new log level: "ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF",
"TRACE", "WARN"
+#' @param sc Spark Context to use
+#' @param level New log level
+#' @examples
--- End diff --
Thank you, @felixcheung . I'll fix soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212695682 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56443/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212695680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212695528 **[Test build #56443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56443/consoleFull)** for PR 12547 at commit [`bba40ca`](https://github.com/apache/spark/commit/bba40ca3e0e7bc5bc5a278f35b0503635d112b40). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/12547#discussion_r60516719
--- Diff: R/pkg/R/context.R ---
@@ -225,3 +225,17 @@ broadcast <- function(sc, object) {
setCheckpointDir <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheckpointDir",
suppressWarnings(normalizePath(dirName
}
+
+#' Set new log level
+#'
+#' Set new log level: "ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF",
"TRACE", "WARN"
+#' @param sc Spark Context to use
+#' @param level New log level
+#' @examples
--- End diff --
please add `@rdname` and `@export` like
[here](https://github.com/apache/spark/commit/14869ae64eb27830179d4954a5dc3e0a1e1330b4#diff-d97f9adc2dcac0703568c799ff106987R1018)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212672853 Sure~ I usually want to switch the log levels for debugging purpose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212672449 @dongjoon-hyun in addition to `setLogLevel` you can always update the log4j properties file (but it can be useful to be able to change it mid program so I understand). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212671826 Hi, @shivaram and @davies . Could you review this PR when you have some time? Whenever I use SparkR, I feel `setLogLevel` is really needed for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212667618 **[Test build #56448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56448/consoleFull)** for PR 12547 at commit [`00e9030`](https://github.com/apache/spark/commit/00e9030a19b43fbb63e92f48bbd0ff3ff2340d88). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212667832 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56448/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212667828 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212662588 **[Test build #56448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56448/consoleFull)** for PR 12547 at commit [`00e9030`](https://github.com/apache/spark/commit/00e9030a19b43fbb63e92f48bbd0ff3ff2340d88). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12547#discussion_r60509109
--- Diff: R/pkg/R/context.R ---
@@ -225,3 +225,17 @@ broadcast <- function(sc, object) {
setCheckpointDir <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheckpointDir",
suppressWarnings(normalizePath(dirName
}
+
+#' Set new log level
+#'
+#' Set new log level: "ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF",
"TRACE", "WARN"
+#' @param sc existing spark context
--- End diff --
Thank you for review, @holdenk . I'll fix like that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12547#discussion_r60508406
--- Diff: R/pkg/R/context.R ---
@@ -225,3 +225,17 @@ broadcast <- function(sc, object) {
setCheckpointDir <- function(sc, dirName) {
invisible(callJMethod(sc, "setCheckpointDir",
suppressWarnings(normalizePath(dirName
}
+
+#' Set new log level
+#'
+#' Set new log level: "ALL", "DEBUG", "ERROR", "FATAL", "INFO", "OFF",
"TRACE", "WARN"
+#' @param sc existing spark context
--- End diff --
"existing spark context" reads a bit oddly, maybe go with "Spark Context to
use" which is what the sc param is called in the other functions in this file
for consistencies sake?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14780][R] Add `setLogLevel` to SparkR
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12547#issuecomment-212657771 **[Test build #56443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56443/consoleFull)** for PR 12547 at commit [`bba40ca`](https://github.com/apache/spark/commit/bba40ca3e0e7bc5bc5a278f35b0503635d112b40). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
