[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-213252594 Does it work in whole stage codegen? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-213243926 Merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-213241810 @rxin I updated the pr description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-213025223 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-213021325 @ueshin in the pr description can you elaborate the approach taken in this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-213021087 cc @davies and @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212820151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56503/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212820148 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212819877 **[Test build #56503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56503/consoleFull)** for PR 12559 at commit [`6c037d0`](https://github.com/apache/spark/commit/6c037d0f477edbd0597fecce08aa23f96d925e6c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212782485 **[Test build #56503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56503/consoleFull)** for PR 12559 at commit [`6c037d0`](https://github.com/apache/spark/commit/6c037d0f477edbd0597fecce08aa23f96d925e6c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212768063 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56483/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212768061 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212767969 **[Test build #56483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56483/consoleFull)** for PR 12559 at commit [`e7afed9`](https://github.com/apache/spark/commit/e7afed92a21835bbb6d92df2dbd51fa872e2dbfa). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212751784 **[Test build #56483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56483/consoleFull)** for PR 12559 at commit [`e7afed9`](https://github.com/apache/spark/commit/e7afed92a21835bbb6d92df2dbd51fa872e2dbfa). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212750650 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212750651 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56481/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212750649 **[Test build #56481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56481/consoleFull)** for PR 12559 at commit [`f17f42a`](https://github.com/apache/spark/commit/f17f42ac60e46fd26586dc9cb960689d7869f700). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12559#issuecomment-212750481 **[Test build #56481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56481/consoleFull)** for PR 12559 at commit [`f17f42a`](https://github.com/apache/spark/commit/f17f42ac60e46fd26586dc9cb960689d7869f700). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14793][SQL] Code generation for large c...
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/12559 [SPARK-14793][SQL] Code generation for large complex type exceeds JVM size limit. ## What changes were proposed in this pull request? Code generation for complex type, `CreateArray`, `CreateMap`, `CreateStruct`, `CreateNamedStruct`, exceeds JVM size limit for large elements. ## How was this patch tested? I added some tests to check if the generated codes for the expressions exceed or not. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ueshin/apache-spark issues/SPARK-14793 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12559.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12559 commit f17f42ac60e46fd26586dc9cb960689d7869f700 Author: Takuya UESHIN Date: 2016-04-21T05:14:42Z Split wide complex type creation into blocks due to JVM code size limit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
