[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12759


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[marmbrus]

Github user marmbrus commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215891359
  
Thanks, merging to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215638073
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57310/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215638072
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215637965
  
**[Test build #57310 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57310/consoleFull)**
 for PR 12759 at commit 
[`9b0d518`](https://github.com/apache/spark/commit/9b0d5187fb7c7dc9d9f648a3badf7130c6df6050).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215628417
  
**[Test build #57310 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57310/consoleFull)**
 for PR 12759 at commit 
[`9b0d518`](https://github.com/apache/spark/commit/9b0d5187fb7c7dc9d9f648a3badf7130c6df6050).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[liancheng]

Github user liancheng commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215628056
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215607453
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215607455
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57292/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215607382
  
**[Test build #57292 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57292/consoleFull)**
 for PR 12759 at commit 
[`9b0d518`](https://github.com/apache/spark/commit/9b0d5187fb7c7dc9d9f648a3badf7130c6df6050).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215599697
  
**[Test build #57292 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57292/consoleFull)**
 for PR 12759 at commit 
[`9b0d518`](https://github.com/apache/spark/commit/9b0d5187fb7c7dc9d9f648a3badf7130c6df6050).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215527193
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57264/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215527190
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215527012
  
**[Test build #57264 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57264/consoleFull)**
 for PR 12759 at commit 
[`5a3aa2c`](https://github.com/apache/spark/commit/5a3aa2c55a3d7a600887e82b9663b52a366a4842).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12759#issuecomment-215513532
  
**[Test build #57264 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57264/consoleFull)**
 for PR 12759 at commit 
[`5a3aa2c`](https://github.com/apache/spark/commit/5a3aa2c55a3d7a600887e82b9663b52a366a4842).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14981][SQL] Throws exception if DESC is...

[liancheng]

GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/12759

[SPARK-14981][SQL] Throws exception if DESC is specified for sorting columns

## What changes were proposed in this pull request?

Currently Spark SQL doesn't support sorting columns in descending order. 
However, the parser accepts the syntax and silently drops sorting directions. 
This PR fixes this by throwing an exception if `DESC` is specified as sorting 
direction of a sorting column.

## How was this patch tested?

A test case is added to test the invalid sorting order by checking 
exception message.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark spark-14981

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12759


commit 5a3aa2c55a3d7a600887e82b9663b52a366a4842
Author: Cheng Lian 
Date:   2016-04-28T17:46:16Z

Throws exception if DESC is specified for sorting columns




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org