[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[viirya]

Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/12769#discussion_r61534645
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -132,7 +132,6 @@ statement
 hiveNativeCommands
--- End diff --

Also `hiveNativeCommands #executeNativeCommand`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[viirya]

Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/12769#discussion_r61534626
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -132,7 +132,6 @@ statement
 hiveNativeCommands
--- End diff --

Since we don't have `visitExecuteNativeCommand` now, do we still need this 
rule?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12769


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215627044
  
Merging in master.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215626945
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57303/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215626944
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215626863
  
**[Test build #57303 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57303/consoleFull)**
 for PR 12769 at commit 
[`308a896`](https://github.com/apache/spark/commit/308a89682624967a0c65985585adb951cbad5d4c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215618498
  
**[Test build #57303 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57303/consoleFull)**
 for PR 12769 at commit 
[`308a896`](https://github.com/apache/spark/commit/308a89682624967a0c65985585adb951cbad5d4c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215618149
  
test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215617795
  
**[Test build #2924 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2924/consoleFull)**
 for PR 12769 at commit 
[`308a896`](https://github.com/apache/spark/commit/308a89682624967a0c65985585adb951cbad5d4c).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215615011
  
**[Test build #2924 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2924/consoleFull)**
 for PR 12769 at commit 
[`308a896`](https://github.com/apache/spark/commit/308a89682624967a0c65985585adb951cbad5d4c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215603503
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215603485
  
**[Test build #57291 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57291/consoleFull)**
 for PR 12769 at commit 
[`308a896`](https://github.com/apache/spark/commit/308a89682624967a0c65985585adb951cbad5d4c).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215603455
  
**[Test build #2919 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2919/consoleFull)**
 for PR 12769 at commit 
[`ca81d24`](https://github.com/apache/spark/commit/ca81d249633924e6f3d897dc4dfba34d2dcbbe71).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215603504
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57291/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215602538
  
**[Test build #57288 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57288/consoleFull)**
 for PR 12769 at commit 
[`ca81d24`](https://github.com/apache/spark/commit/ca81d249633924e6f3d897dc4dfba34d2dcbbe71).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215602554
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215602555
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57288/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215602145
  
**[Test build #2915 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2915/consoleFull)**
 for PR 12769 at commit 
[`ca81d24`](https://github.com/apache/spark/commit/ca81d249633924e6f3d897dc4dfba34d2dcbbe71).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215601024
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57285/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/12769#discussion_r61523246
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
 ---
@@ -97,7 +97,7 @@ class DataSourceWithHiveMetastoreCatalogSuite
 assert(columns.map(_.dataType) === Seq("decimal(10,3)", "string"))
 
 checkAnswer(table("t"), testDF)
-assert(sessionState.runNativeSql("SELECT * FROM t") === 
Seq("1.1\t1", "2.1\t2"))
+assert(sessionState.metadataHive.runSqlHive("SELECT * FROM t") === 
Seq("1.1\t1", "2.1\t2"))
--- End diff --

It will but we are trying to test how Hive would behave here ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215601023
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215600941
  
**[Test build #57285 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57285/consoleFull)**
 for PR 12769 at commit 
[`2eeb627`](https://github.com/apache/spark/commit/2eeb6273c53eb1efa1f0069c9889adfb4961758d).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215600903
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[andrewor14]

Github user andrewor14 commented on a diff in the pull request:

https://github.com/apache/spark/pull/12769#discussion_r61523125
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
 ---
@@ -97,7 +97,7 @@ class DataSourceWithHiveMetastoreCatalogSuite
 assert(columns.map(_.dataType) === Seq("decimal(10,3)", "string"))
 
 checkAnswer(table("t"), testDF)
-assert(sessionState.runNativeSql("SELECT * FROM t") === 
Seq("1.1\t1", "2.1\t2"))
+assert(sessionState.metadataHive.runSqlHive("SELECT * FROM t") === 
Seq("1.1\t1", "2.1\t2"))
--- End diff --

do these work if it's just `sql`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215599688
  
**[Test build #57291 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57291/consoleFull)**
 for PR 12769 at commit 
[`308a896`](https://github.com/apache/spark/commit/308a89682624967a0c65985585adb951cbad5d4c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215599604
  
**[Test build #2913 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2913/consoleFull)**
 for PR 12769 at commit 
[`b0eed5e`](https://github.com/apache/spark/commit/b0eed5e62a1cf8b2e7e997af44f5ebf5b8f84025).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215599569
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215599570
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57284/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215599488
  
**[Test build #57284 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57284/consoleFull)**
 for PR 12769 at commit 
[`b0eed5e`](https://github.com/apache/spark/commit/b0eed5e62a1cf8b2e7e997af44f5ebf5b8f84025).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215599348
  
**[Test build #2919 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2919/consoleFull)**
 for PR 12769 at commit 
[`ca81d24`](https://github.com/apache/spark/commit/ca81d249633924e6f3d897dc4dfba34d2dcbbe71).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215598308
  
**[Test build #57288 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57288/consoleFull)**
 for PR 12769 at commit 
[`ca81d24`](https://github.com/apache/spark/commit/ca81d249633924e6f3d897dc4dfba34d2dcbbe71).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215598039
  
**[Test build #2915 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2915/consoleFull)**
 for PR 12769 at commit 
[`ca81d24`](https://github.com/apache/spark/commit/ca81d249633924e6f3d897dc4dfba34d2dcbbe71).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215594994
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[yhuai]

Github user yhuai commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215593452
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215593412
  
**[Test build #57285 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57285/consoleFull)**
 for PR 12769 at commit 
[`2eeb627`](https://github.com/apache/spark/commit/2eeb6273c53eb1efa1f0069c9889adfb4961758d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215593055
  
**[Test build #2913 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2913/consoleFull)**
 for PR 12769 at commit 
[`b0eed5e`](https://github.com/apache/spark/commit/b0eed5e62a1cf8b2e7e997af44f5ebf5b8f84025).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215591840
  
**[Test build #57284 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57284/consoleFull)**
 for PR 12769 at commit 
[`b0eed5e`](https://github.com/apache/spark/commit/b0eed5e62a1cf8b2e7e997af44f5ebf5b8f84025).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/12769#issuecomment-215591665
  
Note that HiveCompatibilitySuite will fail because I haven't removed the 
unsupported commands yet.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-14991][SQL] Remove HiveNativeCommand

[rxin]

GitHub user rxin opened a pull request:

https://github.com/apache/spark/pull/12769

[SPARK-14991][SQL] Remove HiveNativeCommand

## What changes were proposed in this pull request?
This patch removes HiveNativeCommand, so we can continue to remove the 
dependency on Hive.

## How was this patch tested?
Updated tests to reflect this.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rxin/spark SPARK-14991

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12769


commit b0eed5e62a1cf8b2e7e997af44f5ebf5b8f84025
Author: Reynold Xin 
Date:   2016-04-28T23:25:07Z

[SPARK-14991][SQL] Remove HiveNativeCommand




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org