[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/12875


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-43469
  
Merging with master and branch-2.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-42360
  
**[Test build #3028 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3028/consoleFull)**
 for PR 12875 at commit 
[`171f8e7`](https://github.com/apache/spark/commit/171f8e75495f76444dfbfde640b43e80c0d914e6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-39526
  
**[Test build #3028 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3028/consoleFull)**
 for PR 12875 at commit 
[`171f8e7`](https://github.com/apache/spark/commit/171f8e75495f76444dfbfde640b43e80c0d914e6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-27915
  
No problem.  LGTM, but I'll rerun tests since there are many changes going 
on!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221751818
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59324/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221751760
  
**[Test build #59324 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59324/consoleFull)**
 for PR 12875 at commit 
[`171f8e7`](https://github.com/apache/spark/commit/171f8e75495f76444dfbfde640b43e80c0d914e6).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221751817
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221750413
  
**[Test build #59324 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59324/consoleFull)**
 for PR 12875 at commit 
[`171f8e7`](https://github.com/apache/spark/commit/171f8e75495f76444dfbfde640b43e80c0d914e6).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221749516
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59319/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221749515
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221749495
  
**[Test build #59319 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59319/consoleFull)**
 for PR 12875 at commit 
[`b7ff155`](https://github.com/apache/spark/commit/b7ff155870e2df66179eb1c7129af0620fcf3059).
 * This patch **fails MiMa tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221748487
  
**[Test build #59319 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59319/consoleFull)**
 for PR 12875 at commit 
[`b7ff155`](https://github.com/apache/spark/commit/b7ff155870e2df66179eb1c7129af0620fcf3059).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[yinxusen]

Github user yinxusen commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221748096
  
Sorry for the mistake. Fixed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221746758
  
Thanks for updating it.  In the merge, the old OneVsRest test was 
reinstated.  Could you please remove it again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221478643
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59257/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221478641
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221478570
  
**[Test build #59257 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59257/consoleFull)**
 for PR 12875 at commit 
[`218ecba`](https://github.com/apache/spark/commit/218ecba594f15fafa8c1424a04e780e4af49b9a7).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221477146
  
**[Test build #59257 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59257/consoleFull)**
 for PR 12875 at commit 
[`218ecba`](https://github.com/apache/spark/commit/218ecba594f15fafa8c1424a04e780e4af49b9a7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221474796
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221474798
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59255/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221474776
  
**[Test build #59255 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59255/consoleFull)**
 for PR 12875 at commit 
[`39e5361`](https://github.com/apache/spark/commit/39e5361215a1107d954faecd0c15ab16ad23a580).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221473671
  
**[Test build #59255 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59255/consoleFull)**
 for PR 12875 at commit 
[`39e5361`](https://github.com/apache/spark/commit/39e5361215a1107d954faecd0c15ab16ad23a580).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-221032690
  
Sorry for the delay.  This LGTM once the merge conflicts are fixed and 
tests pass


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[yinxusen]

Github user yinxusen commented on a diff in the pull request:

https://github.com/apache/spark/pull/12875#discussion_r61972815
  
--- Diff: python/pyspark/ml/classification.py ---
@@ -1172,6 +1175,53 @@ def getClassifier(self):
 """
 return self.getOrDefault(self.classifier)
 
+@classmethod
--- End diff --

I deleted them since they are only useful with previous save/load for 
tuning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216693690
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216693691
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57685/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216693542
  
**[Test build #57685 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57685/consoleFull)**
 for PR 12875 at commit 
[`4379239`](https://github.com/apache/spark/commit/43792393353ec394831f33f561153fc72733fa50).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216691635
  
**[Test build #57685 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57685/consoleFull)**
 for PR 12875 at commit 
[`4379239`](https://github.com/apache/spark/commit/43792393353ec394831f33f561153fc72733fa50).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216689763
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216689764
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57682/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216689747
  
**[Test build #57682 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57682/consoleFull)**
 for PR 12875 at commit 
[`e035095`](https://github.com/apache/spark/commit/e0350955504c38213ce745feaff3a686535253b0).
 * This patch **fails PySpark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216687917
  
**[Test build #57682 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57682/consoleFull)**
 for PR 12875 at commit 
[`e035095`](https://github.com/apache/spark/commit/e0350955504c38213ce745feaff3a686535253b0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216679936
  
@yinxusen Thanks!  I made an initial pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/12875#discussion_r61964928
  
--- Diff: python/pyspark/ml/classification.py ---
@@ -1172,6 +1175,53 @@ def getClassifier(self):
 """
 return self.getOrDefault(self.classifier)
 
+@classmethod
--- End diff --

None of these additions to OneVsRestParams are needed to make the tests 
run.  I thought they were only needed for tuning.py persistence.  Are they used 
anywhere?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/12875#discussion_r61961543
  
--- Diff: python/pyspark/ml/tests.py ---
@@ -772,6 +798,25 @@ def test_nested_pipeline_persistence(self):
 except OSError:
 pass
 
+def test_onevsrest(self):
--- End diff --

This is similar to the persistence test in OneVsRestTests.  Can you please 
remove the old one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/12875#discussion_r61961538
  
--- Diff: python/pyspark/ml/tests.py ---
@@ -684,12 +684,32 @@ def test_logistic_regression(self):
 except OSError:
 pass
 
+def _compare_params(self, m1, m2, param):
+"""
+Compare 2 ML params, assert they have the same param. The param 
must be a parameter of m1.
+"""
+# Prevent key not found error in case of some param neither in 
paramMap and
--- End diff --

"neither in paramMap and defaultParamMap" --> "in neither paramMap nor 
defaultParamMap"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/12875#discussion_r61961580
  
--- Diff: python/pyspark/ml/classification.py ---
@@ -40,7 +41,7 @@
'RandomForestClassifier', 'RandomForestClassificationModel',
'NaiveBayes', 'NaiveBayesModel',
'MultilayerPerceptronClassifier', 
'MultilayerPerceptronClassificationModel',
-   'OneVsRest', 'OneVsRestModel']
+   'OneVsRest', 'OneVsRestModel', 'OneVsRestParams']
--- End diff --

OneVsRestParams should be private, so don't add it here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[jkbradley]

Github user jkbradley commented on a diff in the pull request:

https://github.com/apache/spark/pull/12875#discussion_r61961533
  
--- Diff: python/pyspark/ml/tests.py ---
@@ -684,12 +684,32 @@ def test_logistic_regression(self):
 except OSError:
 pass
 
+def _compare_params(self, m1, m2, param):
+"""
+Compare 2 ML params, assert they have the same param. The param 
must be a parameter of m1.
--- End diff --

"Compare 2 ML params, assert they have the same param."
--> "Compare 2 ML Params instances for the given param, and assert both 
have the same param value and parent."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216645995
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216646002
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57660/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216645858
  
**[Test build #57660 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57660/consoleFull)**
 for PR 12875 at commit 
[`a2a0bfe`](https://github.com/apache/spark/commit/a2a0bfea597942e107c8e045e7e33004eb9fb62b).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/12875#issuecomment-216642890
  
**[Test build #57660 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57660/consoleFull)**
 for PR 12875 at commit 
[`a2a0bfe`](https://github.com/apache/spark/commit/a2a0bfea597942e107c8e045e7e33004eb9fb62b).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15008][ML][PySpark] Add integration tes...

[yinxusen]

GitHub user yinxusen opened a pull request:

https://github.com/apache/spark/pull/12875

[SPARK-15008][ML][PySpark] Add integration test for OneVsRest

## What changes were proposed in this pull request?

1. Add `_transfer_param_map_to/from_java` for OneVsRest;

2. Add `_compare_params` in ml/tests.py to help compare params.

3. Add `test_onevsrest` as the integration test for OneVsRest.

## How was this patch tested?

Python unit test.




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yinxusen/spark SPARK-15008

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/12875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12875


commit a2a0bfea597942e107c8e045e7e33004eb9fb62b
Author: yinxusen 
Date:   2016-05-03T19:36:09Z

add integration test for onevsrest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org