[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216593697 Thank you, @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216502775 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216291461 Thank you for review, @hvanhovell and @srowen . For `PasswdAuthenticationProvider`, I didn't change that due to the same reason mentioned by @srowen . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216223534 I agree with all the changes, though some look like they wouldn't have actually been lint errors? I assume we can't fix the `PasswdAuthenticationProvider` file because it's cloned from Hive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12831#discussion_r61728740 --- Diff: dev/checkstyle-suppressions.xml --- @@ -36,4 +36,10 @@ files="src/test/java/org/apache/spark/sql/hive/test/Complex.java"/> + + --- End diff -- How hard is it to fix this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216123922 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216123923 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57505/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216123811 **[Test build #57505 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57505/consoleFull)** for PR 12831 at commit [`3f1c6fa`](https://github.com/apache/spark/commit/3f1c6fa080404b34351d381a5be298d88003f3e9). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216108953 **[Test build #57505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57505/consoleFull)** for PR 12831 at commit [`3f1c6fa`](https://github.com/apache/spark/commit/3f1c6fa080404b34351d381a5be298d88003f3e9). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216108755 PySpark error is irrelevant to this PR. I'll rebase this to retrigger Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216108047 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57503/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216108046 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15053][BUILD] Fix Java Lint errors on H...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12831#issuecomment-216107981 **[Test build #57503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57503/consoleFull)** for PR 12831 at commit [`678cb59`](https://github.com/apache/spark/commit/678cb593acf822770853093f10a10a1b172af4de). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
