[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217286838 Merging into master 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217250400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57904/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217250399 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217250125 **[Test build #57904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57904/consoleFull)** for PR 12851 at commit [`5e464ad`](https://github.com/apache/spark/commit/5e464ad766535061d568bc10d6904d1c96857ef1). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217249543 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217225199 **[Test build #57904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57904/consoleFull)** for PR 12851 at commit [`5e464ad`](https://github.com/apache/spark/commit/5e464ad766535061d568bc10d6904d1c96857ef1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217216308 @techaddict this is getting really close. For the regression test for SPARK-8489 I would just fix it later since this patch doesn't rebuild that jar anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62220691
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/HiveFromSpark.scala
---
@@ -36,13 +36,14 @@ object HiveFromSpark {
def main(args: Array[String]) {
val sparkConf = new SparkConf().setAppName("HiveFromSpark")
-val sc = new SparkContext(sparkConf)
// A hive context adds support for finding tables in the MetaStore and
writing queries
// using HiveQL. Users who do not have an existing Hive deployment can
still create a
// HiveContext. When not configured by the hive-site.xml, the context
automatically
// creates metastore_db and warehouse in the current directory.
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.config(sparkConf).enableHiveSupport().getOrCreate()
+val sc = sparkSession.sparkContext
--- End diff --
github won't let me comment down there, but in L78 please replace `sc.stop`
with `spark.stop`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62220547
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -290,8 +290,9 @@ object SetWarehouseLocationTest extends Logging {
conf.set("spark.sql.warehouse.dir", warehouseLocation.toString)
conf.set("hive.metastore.warehouse.dir",
hiveWarehouseLocation.toString)
-val sc = new SparkContext(conf)
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.config(conf).enableHiveSupport().getOrCreate()
+val sc = sparkSession.sparkContext
--- End diff --
this isn't actually used anywhere...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62220387
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -33,8 +33,14 @@ object Main {
def main(args: Array[String]) {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
-val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+
+val conf = new SparkConf()
+ .setMaster("local")
+ .setAppName("testing")
+
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
this should use the builder's conf method. By the way for this file I would
leave it unchanged and fix it in #12924 instead, since @dilipbiswal is actually
rebuilding the jar there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217096326 @rxin @andrewor14 Comments Addressed, now all tests are passing ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217095292 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217095294 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57849/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217095172 **[Test build #57849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57849/consoleFull)** for PR 12851 at commit [`7ad494d`](https://github.com/apache/spark/commit/7ad494d524f5a920b1719acec183f5c49c4729c3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217083534 **[Test build #57849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57849/consoleFull)** for PR 12851 at commit [`7ad494d`](https://github.com/apache/spark/commit/7ad494d524f5a920b1719acec183f5c49c4729c3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217049798 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57812/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217049795 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217049712 **[Test build #57812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57812/consoleFull)** for PR 12851 at commit [`17e0703`](https://github.com/apache/spark/commit/17e0703ab0a1cf082b6b7a227c3d9631903de3a7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217048754 @techaddict a general point is to try to get the `SparkContext` from the `SparkSession` rather than the other way round. Right now we call `getOrCreate()` and assume there's a `SparkContext` nearby, which may be true but is kind of brittle and outright wrong in some cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137560
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
---
@@ -55,7 +55,7 @@ private[hive] object SparkSQLEnv extends Logging {
maybeKryoReferenceTracking.getOrElse("false"))
sparkContext = new SparkContext(sparkConf)
- sqlContext = SparkSession.withHiveSupport(sparkContext).wrapped
+ sqlContext =
SparkSession.builder.enableHiveSupport().getOrCreate().wrapped
--- End diff --
it would be better if we get the context from the session:
```
val sparkSession =
SparkSession.builder.conf(sparkConf).enableHiveSupport().getOrCreate()
sqlContext = sparkSession.wrapped
sparkContext = sparkSession.sparkContext
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137580
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
---
@@ -55,7 +55,7 @@ private[hive] object SparkSQLEnv extends Logging {
maybeKryoReferenceTracking.getOrElse("false"))
sparkContext = new SparkContext(sparkConf)
- sqlContext = SparkSession.withHiveSupport(sparkContext).wrapped
+ sqlContext =
SparkSession.builder.enableHiveSupport().getOrCreate().wrapped
--- End diff --
actually, we should do something like this everywhere else in this patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137474
--- Diff:
repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -1023,7 +1023,7 @@ class SparkILoop(
val builder = SparkSession.builder.config(conf)
val sparkSession = if (SparkSession.hiveClassesArePresent) {
logInfo("Creating Spark session with Hive support")
- builder.enableHiveSupport().getOrCreate()
+ SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137462
--- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala
---
@@ -89,7 +89,7 @@ object Main extends Logging {
val builder = SparkSession.builder.config(conf)
if (SparkSession.hiveClassesArePresent) {
- sparkSession = builder.enableHiveSupport().getOrCreate()
+ sparkSession = SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
wait, this is wrong now. We want to use the builder we already have
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-217027622 **[Test build #57812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57812/consoleFull)** for PR 12851 at commit [`17e0703`](https://github.com/apache/spark/commit/17e0703ab0a1cf082b6b7a227c3d9631903de3a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216924431 @rxin yupp failed tests are in sql hive tests, waiting for https://github.com/apache/spark/pull/12890 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216667688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57656/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216667685 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216667457 **[Test build #57656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57656/consoleFull)** for PR 12851 at commit [`7a07671`](https://github.com/apache/spark/commit/7a07671294b8f33d9d0c1c4ccde395d91ce54e0e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216630447 **[Test build #57656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57656/consoleFull)** for PR 12851 at commit [`7a07671`](https://github.com/apache/spark/commit/7a07671294b8f33d9d0c1c4ccde395d91ce54e0e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216628798 Jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216625171 Seems like some legitimate failure/? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61927456
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
let's just fix it later
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61898180
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
Since we not longer create a assembly jar, not sure how to create the
jar(steps could be found here https://github.com/apache/spark/pull/11630).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216427871 **[Test build #2961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2961/consoleFull)** for PR 12851 at commit [`7a07671`](https://github.com/apache/spark/commit/7a07671294b8f33d9d0c1c4ccde395d91ce54e0e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216411192 **[Test build #2961 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2961/consoleFull)** for PR 12851 at commit [`7a07671`](https://github.com/apache/spark/commit/7a07671294b8f33d9d0c1c4ccde395d91ce54e0e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216410962 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216410883 **[Test build #57569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57569/consoleFull)** for PR 12851 at commit [`7a07671`](https://github.com/apache/spark/commit/7a07671294b8f33d9d0c1c4ccde395d91ce54e0e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216410964 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57569/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216403881 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61826618
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
yeah we need to rebuild the jar. There's already a TODO on L31. Right now
the corresponding test in `HiveSparkSubmitSuite` is ignored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61824715
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
In order to use this file, I think it needs to be built into a jar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61822413
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
Not sure I got you ? do you mean something like `withSparkContext(sc)`
instead of `getOrCreate()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61821921
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
`enableHiveSupport(sparkContext)` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61821254
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
println("Running regression test for SPARK-8489.")
val sc = new SparkContext("local", "testing")
-val sparkSession = SparkSession.withHiveSupport(sc)
+val sparkSession =
SparkSession.builder.enableHiveSupport().getOrCreate()
--- End diff --
i think this one needs to be built?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12851#issuecomment-216390411 **[Test build #57569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57569/consoleFull)** for PR 12851 at commit [`7a07671`](https://github.com/apache/spark/commit/7a07671294b8f33d9d0c1c4ccde395d91ce54e0e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15072][SQL][REPL][EXAMPLES] Remove Spar...
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/12851 [SPARK-15072][SQL][REPL][EXAMPLES] Remove SparkSession.withHiveSupport ## What changes were proposed in this pull request? Removing the `withHiveSupport` method of `SparkSession`, instead use `enableHiveSupport` ## How was this patch tested? ran tests locally You can merge this pull request into a Git repository by running: $ git pull https://github.com/techaddict/spark SPARK-15072 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12851.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12851 commit 7a07671294b8f33d9d0c1c4ccde395d91ce54e0e Author: Sandeep Singh Date: 2016-05-02T22:56:31Z [SPARK-15072][SQL][REPL][EXAMPLES] Remove SparkSession.withHiveSupport --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
