[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217602079 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12953 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217495549 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58000/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217495546 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217495328 **[Test build #58000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58000/consoleFull)** for PR 12953 at commit [`dbb6632`](https://github.com/apache/spark/commit/dbb663222ba379fbf0b846e2342173f0f0a0ecef). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217468171 **[Test build #58000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58000/consoleFull)** for PR 12953 at commit [`dbb6632`](https://github.com/apache/spark/commit/dbb663222ba379fbf0b846e2342173f0f0a0ecef). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12953#discussion_r62342197
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -389,11 +389,10 @@ private[spark] class TaskSchedulerImpl(
// (taskId, stageId, stageAttemptId, accumUpdates)
val accumUpdatesWithTaskIds: Array[(Long, Int, Int,
Seq[AccumulableInfo])] = synchronized {
accumUpdates.flatMap { case (id, updates) =>
-// We should call `acc.value` here as we are at driver side now.
However, the RPC framework
+// We call `acc.value` here as we are at driver side now.
However, the RPC framework
--- End diff --
@srowen @cloud-fan Done ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12953#discussion_r62340446
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -389,11 +389,10 @@ private[spark] class TaskSchedulerImpl(
// (taskId, stageId, stageAttemptId, accumUpdates)
val accumUpdatesWithTaskIds: Array[(Long, Int, Int,
Seq[AccumulableInfo])] = synchronized {
accumUpdates.flatMap { case (id, updates) =>
-// We should call `acc.value` here as we are at driver side now.
However, the RPC framework
+// We call `acc.value` here as we are at driver side now.
However, the RPC framework
--- End diff --
Since we have no `localValue` anymore, this comment can be removed entirely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217449336 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57990/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217449332 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12953#issuecomment-217449102 **[Test build #57990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57990/consoleFull)** for PR 12953 at commit [`032e042`](https://github.com/apache/spark/commit/032e042b55fbd8a5fcc932e29c6654d68b499c5b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12953#discussion_r62330597
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -389,11 +389,10 @@ private[spark] class TaskSchedulerImpl(
// (taskId, stageId, stageAttemptId, accumUpdates)
val accumUpdatesWithTaskIds: Array[(Long, Int, Int,
Seq[AccumulableInfo])] = synchronized {
accumUpdates.flatMap { case (id, updates) =>
-// We should call `acc.value` here as we are at driver side now.
However, the RPC framework
+// We call `acc.value` here as we are at driver side now.
However, the RPC framework
--- End diff --
The comment was added recently(https://github.com/apache/spark/pull/12795),
so not sure. cc: @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12953#discussion_r62328925
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -389,11 +389,10 @@ private[spark] class TaskSchedulerImpl(
// (taskId, stageId, stageAttemptId, accumUpdates)
val accumUpdatesWithTaskIds: Array[(Long, Int, Int,
Seq[AccumulableInfo])] = synchronized {
accumUpdates.flatMap { case (id, updates) =>
-// We should call `acc.value` here as we are at driver side now.
However, the RPC framework
+// We call `acc.value` here as we are at driver side now.
However, the RPC framework
--- End diff --
The "However..." bit also sounds out of date. Is this problem actually no
longer an issue? then this whole comment can be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
