[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219332692 **[Test build #58623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58623/consoleFull)** for PR 13112 at commit [`ff0b7fd`](https://github.com/apache/spark/commit/ff0b7fd0fc7218d599d1930f1631821f7081532c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219296347 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58613/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219296346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219296305 **[Test build #58613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58613/consoleFull)** for PR 13112 at commit [`fbea7a3`](https://github.com/apache/spark/commit/fbea7a3660c80694b79020d5b885b7a47eae3beb). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219292014 Those do look like instances that can be changed, yes. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user WeichenXu123 commented on the pull request:
https://github.com/apache/spark/pull/13112#issuecomment-219291622
@srowen I use Intellj-IDEA to search usage of deprecate
SparkContext.accumulator in the whole spark project, and update the
code.(except those test code for accumulator method itself)
@HyukjinKwon I update import org.apache.spark.{SparkContext} ==> import
org.apache.spark.SparkContext
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219291395 **[Test build #58613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58613/consoleFull)** for PR 13112 at commit [`fbea7a3`](https://github.com/apache/spark/commit/fbea7a3660c80694b79020d5b885b7a47eae3beb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219208034 Rather than change this in just a couple places, can you update all internal usages of the old accumulator API? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13112#discussion_r63272945
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/stopwatches.scala
---
@@ -19,7 +19,8 @@ package org.apache.spark.ml.util
import scala.collection.mutable
-import org.apache.spark.{Accumulator, SparkContext}
+import org.apache.spark.{SparkContext}
+import org.apache.spark.util.LongAccumulator;
--- End diff --
(The imports might have to be cleaned up as below:)
```scala
import org.apache.spark.SparkContext
import org.apache.spark.util.LongAccumulator
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58603/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207485 **[Test build #58603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58603/consoleFull)** for PR 13112 at commit [`2761dff`](https://github.com/apache/spark/commit/2761dff513eb2da87464735722807e3ea0ea7676). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207500 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219206065 **[Test build #58603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58603/consoleFull)** for PR 13112 at commit [`2761dff`](https://github.com/apache/spark/commit/2761dff513eb2da87464735722807e3ea0ea7676). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219206010 Jenkins add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219204283 This looks good. ping @mengxr @jkbradley @MLnick Could you help to add @WeichenXu123 to whitelist? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219204019 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/13112 [SPARK-15322][mllib]update deprecate accumulator usage into accumulatorV2 in mllib ## What changes were proposed in this pull request? MLlib code has two position use sc.accumulator method and it is deprecate, update it. mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala line 282 mllib/src/main/scala/org/apache/spark/ml/util/stopwatches.scala line 106 ## How was this patch tested? rerun build and test You can merge this pull request into a Git repository by running: $ git pull https://github.com/WeichenXu123/spark update_accuV2_in_mllib Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/13112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13112 commit 2761dff513eb2da87464735722807e3ea0ea7676 Author: WeichenXu Date: 2016-05-14T06:10:34Z update deprecate accumulator usage into accumulatorV2 in mllib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
