[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-222333667
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59568/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-222333666
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-28 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-222333630
  
**[Test build #59568 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59568/consoleFull)**
 for PR 13122 at commit 
[`5bfa863`](https://github.com/apache/spark/commit/5bfa863633e921ee0da27de6dd3914cf4c435f95).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-28 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-222330991
  
**[Test build #59568 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59568/consoleFull)**
 for PR 13122 at commit 
[`5bfa863`](https://github.com/apache/spark/commit/5bfa863633e921ee0da27de6dd3914cf4c435f95).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-28 Thread gatorsmile
Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-222330922
  
@hvanhovell @yhuai This is also ready to review. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220231132
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58841/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220231131
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220230990
  
**[Test build #58841 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58841/consoleFull)**
 for PR 13122 at commit 
[`84aa14a`](https://github.com/apache/spark/commit/84aa14a5deda14083520e8e23f83cdb7f5bbb2bc).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220230272
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58839/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220230271
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220230146
  
**[Test build #58839 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58839/consoleFull)**
 for PR 13122 at commit 
[`0702178`](https://github.com/apache/spark/commit/0702178a3c485aa316d5b03b3aefb2ea4a228cc2).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220222493
  
**[Test build #58841 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58841/consoleFull)**
 for PR 13122 at commit 
[`84aa14a`](https://github.com/apache/spark/commit/84aa14a5deda14083520e8e23f83cdb7f5bbb2bc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-220222027
  
**[Test build #58839 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58839/consoleFull)**
 for PR 13122 at commit 
[`0702178`](https://github.com/apache/spark/commit/0702178a3c485aa316d5b03b3aefb2ea4a228cc2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63819835
  
--- Diff: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
 ---
@@ -234,6 +234,13 @@ class CliSuite extends SparkFunSuite with 
BeforeAndAfterAll with Logging {
 )
   }
 
+  test("unsupported operations") {
--- End diff --

@hvanhovell The latest changes added the test cases for the unsupported 
operations. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63418286
  
--- Diff: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
 ---
@@ -234,6 +234,13 @@ class CliSuite extends SparkFunSuite with 
BeforeAndAfterAll with Logging {
 )
   }
 
+  test("unsupported operations") {
--- End diff --

Yeah, this is the only we can check if CLI will reject the command. This 
test suite is slow but we can do it for all the unsupported operations. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63417782
  
--- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
@@ -312,7 +311,10 @@ private[hive] class SparkSQLCLIDriver extends 
CliDriver with Logging {
   if (proc != null) {
 // scalastyle:off println
 if (proc.isInstanceOf[Driver] || proc.isInstanceOf[SetProcessor] ||
-  proc.isInstanceOf[AddResourceProcessor]) {
+proc.isInstanceOf[AddResourceProcessor] || 
proc.isInstanceOf[DeleteResourceProcessor] ||
--- End diff --

Yeah, will do it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63417732
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -172,6 +172,10 @@ unsupportedHiveNativeCommands
 | kw1=ROLLBACK
 | kw1=DFS
 | kw1=DELETE kw2=FROM
+| kw1=RELOAD kw2=FUNCTION
+| kw1=DELETE kw2=(FILE | FILES | JAR | JARS | ARCHIVE | ARCHIVES)
--- End diff --

Sure, will do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63417432
  
--- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
@@ -312,7 +311,10 @@ private[hive] class SparkSQLCLIDriver extends 
CliDriver with Logging {
   if (proc != null) {
 // scalastyle:off println
 if (proc.isInstanceOf[Driver] || proc.isInstanceOf[SetProcessor] ||
-  proc.isInstanceOf[AddResourceProcessor]) {
+proc.isInstanceOf[AddResourceProcessor] || 
proc.isInstanceOf[DeleteResourceProcessor] ||
--- End diff --

Pattern match?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63417404
  
--- Diff: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
 ---
@@ -234,6 +234,13 @@ class CliSuite extends SparkFunSuite with 
BeforeAndAfterAll with Logging {
 )
   }
 
+  test("unsupported operations") {
--- End diff --

I suppose there is not a time efficient way to test all commands?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-16 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/13122#discussion_r63417209
  
--- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -172,6 +172,10 @@ unsupportedHiveNativeCommands
 | kw1=ROLLBACK
 | kw1=DFS
 | kw1=DELETE kw2=FROM
+| kw1=RELOAD kw2=FUNCTION
+| kw1=DELETE kw2=(FILE | FILES | JAR | JARS | ARCHIVE | ARCHIVES)
--- End diff --

Could you perhaps do this without adding the `FILE`, `FILES`, `JAR`, 
`JARS`, `ARCHIVE` & `ARCHIVES` keywords? This makes it consistent with the `ADD 
` command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219305196
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219305197
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58614/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219305143
  
**[Test build #58614 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58614/consoleFull)**
 for PR 13122 at commit 
[`3876630`](https://github.com/apache/spark/commit/38766309a35426a6a13d3b3bfa246b07e096bf64).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219300252
  
**[Test build #58614 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58614/consoleFull)**
 for PR 13122 at commit 
[`3876630`](https://github.com/apache/spark/commit/38766309a35426a6a13d3b3bfa246b07e096bf64).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219273140
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58612/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219273139
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219273112
  
**[Test build #58612 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58612/consoleFull)**
 for PR 13122 at commit 
[`25257df`](https://github.com/apache/spark/commit/25257df2e3d4fa6691fc0e8db5ed342ac09ffe9f).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13122#issuecomment-219270699
  
**[Test build #58612 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58612/consoleFull)**
 for PR 13122 at commit 
[`25257df`](https://github.com/apache/spark/commit/25257df2e3d4fa6691fc0e8db5ed342ac09ffe9f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15331] [SQL] Disallow All the Unsupport...

2016-05-15 Thread gatorsmile
GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/13122

[SPARK-15331] [SQL] Disallow All the Unsupported CLI Commands

 What changes were proposed in this pull request?
The JIRAs under https://issues.apache.org/jira/browse/SPARK-14118 remove 
the support of the DDL/CLI commands that are not natively supported by Spark. 
However, in Spark-SQL CLI, we still delegate the CLI commands to Hive command 
processors. To be consistent, we should also remove the related command 
supports in Spark SQL CLI.

Also, we need to improve Parser to issue better error exception messages 
for these unsupported operations. 
```
- DFS,
- RELOAD FUNCTION
- DELETE FILE/FILES/JAR/JARS/ARCHIVE/ARCHIVES
- LIST FILE/FILES/JAR/JARS/ARCHIVE/ARCHIVES
- SOURCE
```
 How was this patch tested?
Added a test case in CliSuite.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark disableCliCommand

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13122


commit 25257df2e3d4fa6691fc0e8db5ed342ac09ffe9f
Author: gatorsmile 
Date:   2016-05-15T07:04:34Z

ban all the unsupported cli commands.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org