[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-220378020
  
**[Test build #58870 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58870/consoleFull)**
 for PR 13142 at commit 
[`fc08879`](https://github.com/apache/spark/commit/fc08879771765d26039d5392a017bdf7aaa9784c).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-220378345
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58870/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-220378344
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-220350310
  
@rxin yeah. To help code review, I split the code changes to two separate 
commits, as shown below
[1) rename two 
files](https://github.com/apache/spark/pull/13142/commits/1e081632f86467a5a392eebc2b6305644d843490)
[2) move test cases from one file to 
another](https://github.com/apache/spark/pull/13142/commits/fc08879771765d26039d5392a017bdf7aaa9784c
)
Hopefully, it can make review easier. Let me know if you have any question. 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-220350381
  
**[Test build #58870 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58870/consoleFull)**
 for PR 13142 at commit 
[`fc08879`](https://github.com/apache/spark/commit/fc08879771765d26039d5392a017bdf7aaa9784c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-220274169
  
Is this mostly moving test cases around? Any idea why the diff is so large? 
This makes it very difficult to review.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-219650975
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-219650978
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58672/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-219650730
  
**[Test build #58672 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58672/consoleFull)**
 for PR 13142 at commit 
[`13c26ff`](https://github.com/apache/spark/commit/13c26ffc15a8fd2729f7bf0ac8aecd6c0fd7e2c4).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-219634169
  
**[Test build #58672 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58672/consoleFull)**
 for PR 13142 at commit 
[`13c26ff`](https://github.com/apache/spark/commit/13c26ffc15a8fd2729f7bf0ac8aecd6c0fd7e2c4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[gatorsmile]

Github user gatorsmile commented on the pull request:

https://github.com/apache/spark/pull/13142#issuecomment-219633544
  
CC @hvanhovell @rxin 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

[gatorsmile]

GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/13142

[SPARK-15358] [TEST] Rename HiveDDLCommandSuite and DDLCommandSuite to 
HivePlanParserSuite and PlanParserSuite

 What changes were proposed in this pull request?
After we moving `HiveSqlParser` to `SparkSqlParser` in 
https://github.com/apache/spark/pull/12556, most of test cases in 
`HiveDDLCommandSuite` should be also moved to `DDLCommandSuite`.

The test suites named `DDLCommandSuite` and `HiveDDLCommandSuite` are very 
confusing. We already have `PlanParserSuite` for `catalyst.parser`. To make 
them consistent, we should rename them. **How about using the same names?** 
They are basically for the same goals. Note, the test cases that remained in 
HivePlanParserSuite require the class in Hive package. 

The changes in this PR can help us check if the test cases for the parser 
are complete and avoid duplicates.  

 How was this patch tested?
N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark combineTwoParserSuites

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13142


commit 0c6b24ad6f81d8f456250feaa22b1ee1e7b437ca
Author: gatorsmile 
Date:   2016-05-17T06:24:07Z

rename files to parsersuite

commit 13c26ffc15a8fd2729f7bf0ac8aecd6c0fd7e2c4
Author: gatorsmile 
Date:   2016-05-17T06:36:53Z

style fix.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org