[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-20 Thread mengxr 
Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/13213#issuecomment-220526674
  
LGTM. Merged into master and branch-2.0. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13213#issuecomment-220519177
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58941/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread AmplabJenkins 
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13213#issuecomment-220519176
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13213#issuecomment-220519138
  
**[Test build #58941 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58941/consoleFull)**
 for PR 13213 at commit 
[`818dc7f`](https://github.com/apache/spark/commit/818dc7fe8f1be835243de8d096d43b229e356cbc).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread SparkQA 
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13213#issuecomment-220518293
  
**[Test build #58941 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58941/consoleFull)**
 for PR 13213 at commit 
[`818dc7f`](https://github.com/apache/spark/commit/818dc7fe8f1be835243de8d096d43b229e356cbc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15363][ML][Example]:Example code should...

2016-05-19 Thread wangmiao1981 
GitHub user wangmiao1981 opened a pull request:

https://github.com/apache/spark/pull/13213

[SPARK-15363][ML][Example]:Example code shouldn't use VectorImplicits._, 
asML/fromML

## What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)
In this DataFrame example, we use VectorImplicits._, which is private API. 

Since Vectors object has public API, we use Vectors.fromML instead of 
implicts.

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)

Manually run the example.





You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wangmiao1981/spark ml

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13213


commit 818dc7fe8f1be835243de8d096d43b229e356cbc
Author: wm...@hotmail.com 
Date:   2016-05-20T05:00:35Z

remove VectorImplicits in example




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org