[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220175949 Oh, thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220175590 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220173646 Hi, @zsxwing . Finally, it passes the Jenkins test. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220172814 **[Test build #2993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2993/consoleFull)** for PR 13158 at commit [`206171a`](https://github.com/apache/spark/commit/206171a679f486cc1568f8a5452c3b2a36c88fff). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220147151 **[Test build #58803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58803/consoleFull)** for PR 13158 at commit [`0fa7d5b`](https://github.com/apache/spark/commit/0fa7d5b2c646ffb4dc882076f6e1dbd6c184b6a4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220147478 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220147479 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58803/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220145888 **[Test build #2993 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2993/consoleFull)** for PR 13158 at commit [`206171a`](https://github.com/apache/spark/commit/206171a679f486cc1568f8a5452c3b2a36c88fff). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220144611 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58801/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220144607 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220144224 **[Test build #58801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58801/consoleFull)** for PR 13158 at commit [`e170041`](https://github.com/apache/spark/commit/e170041a6ecd3041c751000f9d36546f52e99ee8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220138483 **[Test build #58804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58804/consoleFull)** for PR 13158 at commit [`206171a`](https://github.com/apache/spark/commit/206171a679f486cc1568f8a5452c3b2a36c88fff). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220138708 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58804/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220137256 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220137024 **[Test build #58800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58800/consoleFull)** for PR 13158 at commit [`38525b3`](https://github.com/apache/spark/commit/38525b339ace52bb66bd4a591d0d66c6680f52bb). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220137257 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58800/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220138706 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220112134 **[Test build #58804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58804/consoleFull)** for PR 13158 at commit [`206171a`](https://github.com/apache/spark/commit/206171a679f486cc1568f8a5452c3b2a36c88fff). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220112444 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220110453 I'm done. You can test locally now with the up-to-date code. Thank you for review and local testing, @zsxwing ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220110786 **[Test build #58803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58803/consoleFull)** for PR 13158 at commit [`0fa7d5b`](https://github.com/apache/spark/commit/0fa7d5b2c646ffb4dc882076f6e1dbd6c184b6a4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220107972 **[Test build #58801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58801/consoleFull)** for PR 13158 at commit [`e170041`](https://github.com/apache/spark/commit/e170041a6ecd3041c751000f9d36546f52e99ee8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220109621 Oh, wait a moment. I'm testing on refactored method. I'll update the PR very soon again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63751712
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
Sure. That would be great. I'll refactor them like this.
```scala
def getTimeZoneOffset() : Int =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220108576 @dongjoon-hyun looks pretty good. Let me try locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63750743
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
nit: could you add a new method for this line in UIUtils and reuse it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220106807 I see. The `js` files. I'll fix them. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220106461 **[Test build #58800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58800/consoleFull)** for PR 13158 at commit [`38525b3`](https://github.com/apache/spark/commit/38525b339ace52bb66bd4a591d0d66c6680f52bb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220106059 Oh, did I do that? Sorry, but which file did I do that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220105660 @dongjoon-hyun could you revert the changes to the file permission? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220105230 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220104417 **[Test build #58789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58789/consoleFull)** for PR 13158 at commit [`38525b3`](https://github.com/apache/spark/commit/38525b339ace52bb66bd4a591d0d66c6680f52bb). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220104622 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220104624 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58789/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220076246 **[Test build #58789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58789/consoleFull)** for PR 13158 at commit [`38525b3`](https://github.com/apache/spark/commit/38525b339ace52bb66bd4a591d0d66c6680f52bb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-220075551 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-22704 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-22568 **[Test build #58767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58767/consoleFull)** for PR 13158 at commit [`38525b3`](https://github.com/apache/spark/commit/38525b339ace52bb66bd4a591d0d66c6680f52bb). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-22705 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58767/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63675876
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
Oh I did miss that yet. THis LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63675768
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
For example, the second one is correct.
```
scala> java.util.TimeZone.getTimeZone("America/New_York").getRawOffset()
res0: Int = -1800
scala>
java.util.TimeZone.getTimeZone("America/New_York").getOffset(System.currentTimeMillis)
res1: Int = -1440
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63675265
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
Ur, I think you might miss my previous comment about this . Or, did I
really miss something?
> Since getRawOffset does not consider Daylight Saving Time, I needed to
use the above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63674795
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset =
TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
How about getRawOffset here? I think that's what you are looking for?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219977961 **[Test build #58767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58767/consoleFull)** for PR 13158 at commit [`38525b3`](https://github.com/apache/spark/commit/38525b339ace52bb66bd4a591d0d66c6680f52bb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219977931 @srowen . I updated the PR to use `TimeZone.getDefault()`. Thank you again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63674132
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
@@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray,
eventObjArray, startTime) {
editable: false,
showCurrentTime: false,
min: startTime,
-zoomable: false
+zoomable: false,
+moment: function (date) {
+ return vis.moment(date).utcOffset(offset);
--- End diff --
ah right, your formula gives minutes not hours. That seems fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63674102
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset = TimeZone.getTimeZone(System.getProperty("user.timezone"))
+ .getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
Since `getRawOffset` does not consider Daylight Saving Time, I needed to
use the above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63673599
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
@@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray,
eventObjArray, startTime) {
editable: false,
showCurrentTime: false,
min: startTime,
-zoomable: false
+zoomable: false,
+moment: function (date) {
+ return vis.moment(date).utcOffset(offset);
--- End diff --
Unfortunately,
[moment](http://momentjs.com/docs/#/manipulating/utc-offset/) (used by `vis`)
only supports the followings. Actually, this PR is using the last one, `minute`
format.
```javascript
moment().utcOffset("+08:00");
moment().utcOffset(8); // hour: -16 < x < 16
moment().utcOffset(480); // minutes
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63671930
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset = TimeZone.getTimeZone(System.getProperty("user.timezone"))
--- End diff --
Thank you for review, @srowen . I'll replace that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63667936
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset = TimeZone.getTimeZone(System.getProperty("user.timezone"))
+ .getOffset(System.currentTimeMillis()) / 1000 / 60
--- End diff --
`getRawOffset`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63667773
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
@@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray,
eventObjArray, startTime) {
editable: false,
showCurrentTime: false,
min: startTime,
-zoomable: false
+zoomable: false,
+moment: function (date) {
+ return vis.moment(date).utcOffset(offset);
--- End diff --
Does vis support an actual timezone, or just a UTC offset? some timezones'
offsets aren't whole hours :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63667392
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
WebUIPage("") {
val jobEventJsonAsStrSeq = makeJobEvent(jobs)
val executorEventJsonAsStrSeq = makeExecutorEvent(executors)
+val offset = TimeZone.getTimeZone(System.getProperty("user.timezone"))
--- End diff --
I think this is what `TimeZone.getDefault` does, and it takes care of a few
other details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219931535 cc @andrewor14 @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219909074 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219909077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58729/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219908945 **[Test build #58729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58729/consoleFull)** for PR 13158 at commit [`d1bdb32`](https://github.com/apache/spark/commit/d1bdb325870257eb5a15a1978ed50467ceded4ca). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219893989 **[Test build #58729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58729/consoleFull)** for PR 13158 at commit [`d1bdb32`](https://github.com/apache/spark/commit/d1bdb325870257eb5a15a1978ed50467ceded4ca). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13158#issuecomment-219893875 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15373][WEB UI] Spark UI should show con...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/13158
[SPARK-15373][WEB UI] Spark UI should show consistent timezones.
## What changes were proposed in this pull request?
Currently, SparkUI shows two timezones in a single page when the timezone
of browser is different from the server JVM timezone. The following is an
example on Databricks CE which uses 'Etc/UTC' timezone.
- The time of `submitted` column of list and pop-up description shows
`2016/05/18 00:03:07`
- The time of timeline shows `2016/05/17 17:03:07`.
This PR fixes the **timeline chart** to use the same timezone by the
followings.
- Upgrade `vis` from 3.9.0(2015-01-16) to 4.16.1(2016-04-18)
- Override `moment` of `vis` to get `offset`
- Update `AllJobsPage`, `JobPage`, and `StagePage`.
## How was this patch tested?
Manual. Run the following command and see the Spark UI's event timelines.
```
$ SPARK_SUBMIT_OPTS="-Dscala.usejavacp=true -Duser.timezone=Etc/UTC"
bin/spark-submit --class org.apache.spark.repl.Main
...
scala> sql("select 1").head
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-15373
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13158
commit d1bdb325870257eb5a15a1978ed50467ceded4ca
Author: Dongjoon Hyun
Date: 2016-05-17T21:43:28Z
[SPARK-15373][WEB UI] Spark UI should show consistent timezones.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
