[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zsxwing closed the pull request at: https://github.com/apache/spark/pull/13196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220660336 Merging to1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220493923 **[Test build #2994 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2994/consoleFull)** for PR 13196 at commit [`4e58119`](https://github.com/apache/spark/commit/4e581197d0cd5ad9f14f723c16b4824d2ae380bc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220477551 **[Test build #2994 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2994/consoleFull)** for PR 13196 at commit [`4e58119`](https://github.com/apache/spark/commit/4e581197d0cd5ad9f14f723c16b4824d2ae380bc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220470402 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220464958 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58879/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220464957 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220464846 **[Test build #58879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58879/consoleFull)** for PR 13196 at commit [`4e58119`](https://github.com/apache/spark/commit/4e581197d0cd5ad9f14f723c16b4824d2ae380bc). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13196#issuecomment-220401895 **[Test build #58879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58879/consoleFull)** for PR 13196 at commit [`4e58119`](https://github.com/apache/spark/commit/4e581197d0cd5ad9f14f723c16b4824d2ae380bc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220400568 @zzcclp Just opened #13196 to fix it for branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/13196 [SPARK-15395][Core]Use getHostString to create RpcAddress (backport for 1.6) ## What changes were proposed in this pull request? Backport #13185 to branch 1.6. ## How was this patch tested? Jenkins unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zsxwing/spark host-string-1.6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/13196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13196 commit 4e581197d0cd5ad9f14f723c16b4824d2ae380bc Author: Shixiong Zhu Date: 2016-05-19T17:45:08Z [SPARK-15395][Core]Use getHostString to create RpcAddress (backport for 1.6) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220218127 ï¼ zsxwing will this pr be merged into branch 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220217816 Didn't merge to 1.6 due to the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220217602 Thanks. Merging to master, 2.0 and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220212769 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220211449 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220211450 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58830/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220211328 **[Test build #58830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58830/consoleFull)** for PR 13185 at commit [`be7ec5f`](https://github.com/apache/spark/commit/be7ec5ffc140c59935479332698fef640626d8e2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220197267 **[Test build #58830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58830/consoleFull)** for PR 13185 at commit [`be7ec5f`](https://github.com/apache/spark/commit/be7ec5ffc140c59935479332698fef640626d8e2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/13185 [SPARK-15395][Core]Use getHostString to create RpcAddress ## What changes were proposed in this pull request? Right now the netty RPC uses `InetSocketAddress.getHostName` to create `RpcAddress` for network events. If we use an IP address to connect, then the RpcAddress's host will be a host name (if the reverse lookup successes) instead of the IP address. However, some places need to compare the original IP address and the RpcAddress in `onDisconnect` (e.g., CoarseGrainedExecutorBackend), and this behavior will make the check incorrect. This PR uses `getHostString` to resolve the issue. ## How was this patch tested? Jenkins unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zsxwing/spark host-string Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/13185.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13185 commit be7ec5ffc140c59935479332698fef640626d8e2 Author: Shixiong Zhu Date: 2016-05-19T00:03:20Z Use getHostString to create RpcAddress --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15395][Core]Use getHostString to create...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13185#issuecomment-220196803 cc @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
