[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-222035774 @zsxwing sure let's add an abstract layer. I'll rebase and do this in the next two days or so. Thanks for the review! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-221702705 @lw-lin I'm wondering if you can add an abstract layer (e.g., AbstractOutputWriterFactory and AbstractOutputWriter) to eliminate the duplicated codes. There are a lot of duplicated codes in these formats and hard to maintain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-221171715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-221171716 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59176/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-221171564 **[Test build #59176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59176/consoleFull)** for PR 13258 at commit [`936bf26`](https://github.com/apache/spark/commit/936bf26415ae4f8875b091bc1587409620a14e0a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-221148286 **[Test build #59176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59176/consoleFull)** for PR 13258 at commit [`936bf26`](https://github.com/apache/spark/commit/936bf26415ae4f8875b091bc1587409620a14e0a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-220917708 @marmbrus @tdas @zsxwing would you mind taking a look? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-220906144 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59123/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-220906143 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-220905923 **[Test build #59123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59123/consoleFull)** for PR 13258 at commit [`f3bac77`](https://github.com/apache/spark/commit/f3bac77b307cc56aa6c468ef75ab255b5ad85459). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13258#issuecomment-220893879 **[Test build #59123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59123/consoleFull)** for PR 13258 at commit [`f3bac77`](https://github.com/apache/spark/commit/f3bac77b307cc56aa6c468ef75ab255b5ad85459). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add partitioned ...
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/13258
[SPARK-15472][SQL][Streaming] Add partitioned `csv`, `json`, `text` format
support for FileStreamSink
## What changes were proposed in this pull request?
This patch adds partitioned `csv`, `json`, `text` format support for
`FileStreamSink`.
For each format, this patch adds a dedicated `OutputWriterFactory`, which
would return a dedicated `OutputWriter` writing data without using an
`OutputCommitter`. This is the same approach taken by
[SPARK-14716](https://github.com/apache/spark/pull/12409) in which we had added
partitioned `parquet` format support.
## How was this patch tested?
`FileStreamSinkSuite` is expanded to cover the added `csv`, `json`, `text`
format:
```scala
test(" csv - unpartitioned data")
test("json - unpartitioned data")
test("text - unpartitioned data")
test(" csv - partitioned data")
test("json - partitioned data")
test("text - partitioned data")
test(" csv - unpartitioned writing and batch reading")
test("json - unpartitioned writing and batch reading")
test("text - unpartitioned writing and batch reading")
test(" csv - partitioned writing and batch reading")
test("json - partitioned writing and batch reading")
test("text - partitioned writing and batch reading")
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark add-cvs-json-text
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13258.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13258
commit f3bac77b307cc56aa6c468ef75ab255b5ad85459
Author: Liwei Lin
Date: 2016-05-22T08:54:11Z
Add csv, json, text
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
