[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/13394#discussion_r65113954
  
--- Diff: R/pkg/R/stats.R ---
@@ -19,12 +19,11 @@
 
 setOldClass("jobj")
 
-#' crosstab
-#'
 #' Computes a pair-wise frequency table of the given columns. Also known 
as a contingency
 #' table. The number of distinct values for each column should be less 
than 1e4. At most 1e6
 #' non-zero pair frequencies will be returned.
 #'
+#' @title Statistic functions for SparkDataFrames
--- End diff --

please see PR #13109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/13394#discussion_r65113870
  
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1069,7 +1080,10 @@ setMethod("first",
 #'
 #' @param x A SparkDataFrame
 #'
-#' @noRd
+#' @family SparkDataFrame functions
+#' @rdname toRDD
--- End diff --

same here. RDD functions are not exported and not supported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

https://github.com/apache/spark/pull/13394#discussion_r65113846
  
--- Diff: R/pkg/R/DataFrame.R ---
@@ -629,8 +629,9 @@ setMethod("repartition",
 #' @param x A SparkDataFrame
 #' @return A StringRRDD of JSON objects
 #' @family SparkDataFrame functions
-#' @rdname tojson
-#' @noRd
+#' @rdname toJSON
+#' @name toJSON
--- End diff --

wait, why are we changing this from `@noRd`? this is not exported from 
SparkR and should not be documented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[felixcheung]

Github user felixcheung commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222572865
  
> (c) the change to not require sqlContext
This was in the earlier PR, under the migration guide session.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[shivaram]

Github user shivaram commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222560187
  
@vectorijk Thanks for the PR. Changes look pretty good to me. 
We also need to update the programming guide (the one at 
http://spark.apache.org/docs/latest/sparkr.html) to cover the major new 
features. This will include 
(a) UDFs with dapply, dapplyCollect and 
(b) spark.lapply for running parallel R functions
(c) the change to not require `sqlContext` 

We can do that in a separate JIRA/PR or if you wish we can also do it in 
this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[shivaram]

Github user shivaram commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222559900
  
@felixcheung Could you take a look at this PR ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222386802
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222386805
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59600/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222386772
  
**[Test build #59600 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59600/consoleFull)**
 for PR 13394 at commit 
[`7961bbe`](https://github.com/apache/spark/commit/7961bbe8b346ae47a70fa324b18219070197ded8).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222386047
  
**[Test build #59600 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59600/consoleFull)**
 for PR 13394 at commit 
[`7961bbe`](https://github.com/apache/spark/commit/7961bbe8b346ae47a70fa324b18219070197ded8).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[vectorijk]

Github user vectorijk commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222385824
  
Jenkins test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[vectorijk]

Github user vectorijk commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222378580
  
Jenkins test this again please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222354732
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222354730
  
**[Test build #59589 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59589/consoleFull)**
 for PR 13394 at commit 
[`7961bbe`](https://github.com/apache/spark/commit/7961bbe8b346ae47a70fa324b18219070197ded8).
 * This patch **fails MiMa tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222354733
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59589/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222354455
  
**[Test build #59589 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59589/consoleFull)**
 for PR 13394 at commit 
[`7961bbe`](https://github.com/apache/spark/commit/7961bbe8b346ae47a70fa324b18219070197ded8).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[vectorijk]

Github user vectorijk commented on the pull request:

https://github.com/apache/spark/pull/13394#issuecomment-222354451
  
cc @felixcheung @shivaram @sun-rui 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15490][R][DOC] SparkR 2.0 QA: New R API...

[vectorijk]

GitHub user vectorijk opened a pull request:

https://github.com/apache/spark/pull/13394

[SPARK-15490][R][DOC] SparkR 2.0 QA: New R APIs and API docs for non-MLib 
changes

## What changes were proposed in this pull request?
R Docs changes
include typos, format, layout.
## How was this patch tested?
Test locally.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vectorijk/spark spark-15490

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13394


commit 7961bbe8b346ae47a70fa324b18219070197ded8
Author: Kai Jiang 
Date:   2016-05-29T02:09:22Z

QA for non-MLlib changes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org