[GitHub] spark pull request: [SPARK-15493][SQL] default QuoteEscapingEnable...

2016-05-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15493][SQL] default QuoteEscapingEnable...

2016-05-25 Thread rxin
Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13267#issuecomment-221684056
  
Thanks - merging in master/2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15493][SQL] default QuoteEscapingEnable...

2016-05-25 Thread jurriaan
Github user jurriaan commented on a diff in the pull request:

https://github.com/apache/spark/pull/13267#discussion_r64547155
  
--- Diff: sql/core/pom.xml ---
@@ -39,7 +39,7 @@
 
   com.univocity
   univocity-parsers
-  2.1.0
+  2.1.1
--- End diff --

I've updated some dep lists, tests are green, what do you mean exactly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-15493][SQL] default QuoteEscapingEnable...

2016-05-25 Thread jurriaan
Github user jurriaan commented on a diff in the pull request:

https://github.com/apache/spark/pull/13267#discussion_r64544204
  
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -787,6 +787,9 @@ def csv(self, path, mode=None, compression=None, 
sep=None, quote=None, escape=No
   value, ``"``.
 :param escape: sets the single character used for escaping quotes 
inside an already
quoted value. If None is set, it uses the default 
value, ``\``
+:param escapeQuotes: A flag indicating whether values containing 
quotes should always
+ be enclosed in quotes. Default is to escape 
all values containing
+ a quote character. ``true``
--- End diff --

Oops :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org