[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[WeichenXu123]

Github user WeichenXu123 closed the pull request at:

https://github.com/apache/spark/pull/13313


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13312


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221759601
  
Merging in master/2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221759356
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221759357
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59322/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221759209
  
**[Test build #59322 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59322/consoleFull)**
 for PR 13312 at commit 
[`eee2f27`](https://github.com/apache/spark/commit/eee2f27e8c12f65879bd983838bf73a1dec95c61).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221756714
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59315/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221756710
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221756581
  
**[Test build #59315 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59315/consoleFull)**
 for PR 13312 at commit 
[`9c66cb1`](https://github.com/apache/spark/commit/9c66cb19b4d7ce58946f91b54ec4acf110618d5a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13313#issuecomment-221756271
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13313#issuecomment-221756209
  
**[Test build #59317 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59317/consoleFull)**
 for PR 13313 at commit 
[`aaac61a`](https://github.com/apache/spark/commit/aaac61a015133ac09a92a8edaeea423254d94d8b).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13313#issuecomment-221756274
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59317/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13313#issuecomment-221749486
  
@WeichenXu123 looks like @sameeragarwal beat you to it ... 
https://github.com/apache/spark/pull/13312




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221749437
  
LGTM pending tests.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221749105
  
**[Test build #59322 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59322/consoleFull)**
 for PR 13312 at commit 
[`eee2f27`](https://github.com/apache/spark/commit/eee2f27e8c12f65879bd983838bf73a1dec95c61).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[sameeragarwal]

Github user sameeragarwal commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221749009
  
Removed labels and converted the examples to use the alternatives.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13313#issuecomment-221748485
  
**[Test build #59317 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59317/consoleFull)**
 for PR 13313 at commit 
[`aaac61a`](https://github.com/apache/spark/commit/aaac61a015133ac09a92a8edaeea423254d94d8b).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL]Deprecate Dataset.explode

[WeichenXu123]

GitHub user WeichenXu123 opened a pull request:

https://github.com/apache/spark/pull/13313

[SPARK-15533][SQL]Deprecate Dataset.explode

## What changes were proposed in this pull request?

Deprecate Dataset.explode


## How was this patch tested?

Existing test.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WeichenXu123/spark fix-SPARK-15533

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13313


commit aaac61a015133ac09a92a8edaeea423254d94d8b
Author: WeichenXu 
Date:   2016-05-25T23:15:40Z

Deprecate Dataset.explode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13312#discussion_r64675778
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1596,7 +1609,7 @@ class Dataset[T] private[sql](
   }
 
   /**
-   * :: Experimental ::
+   * :: Deprecated ::
--- End diff --

remove this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13312#discussion_r64675785
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1605,10 +1618,23 @@ class Dataset[T] private[sql](
*   ds.explode("words", "word") {words: String => words.split(" ")}
* }}}
--- End diff --

remove old example


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13312#discussion_r64675774
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1576,10 +1576,23 @@ class Dataset[T] private[sql](
*   val bookCountPerWord = 
allWords.groupBy("word").agg(countDistinct("title"))
--- End diff --

we can remove the old examples now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13312#discussion_r64675619
  
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1556,7 +1556,7 @@ class Dataset[T] private[sql](
   }
 
   /**
-   * :: Experimental ::
+   * :: Deprecated ::
--- End diff --

remove this we don't have a label like this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13312#issuecomment-221746455
  
**[Test build #59315 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59315/consoleFull)**
 for PR 13312 at commit 
[`9c66cb1`](https://github.com/apache/spark/commit/9c66cb19b4d7ce58946f91b54ec4acf110618d5a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15533][SQL] Deprecate Dataset.explode

[sameeragarwal]

GitHub user sameeragarwal opened a pull request:

https://github.com/apache/spark/pull/13312

[SPARK-15533][SQL] Deprecate Dataset.explode

## What changes were proposed in this pull request?

This patch deprecates `Dataset.explode` and documents appropriate 
workarounds to use `flatMap()` or `functions.explode()` instead.

## How was this patch tested?

N/A

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sameeragarwal/spark deprecate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13312


commit 9c66cb19b4d7ce58946f91b54ec4acf110618d5a
Author: Sameer Agarwal 
Date:   2016-05-26T00:22:10Z

Deprecate Dataset.explode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org