[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13364


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-89156
  
Merging in master/2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-86984
  
**[Test build #3029 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3029/consoleFull)**
 for PR 13364 at commit 
[`f44883f`](https://github.com/apache/spark/commit/f44883f2d0d16d3554c332f485b4a53a0ab41a76).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `public class Java8RDDAPISuite implements Serializable `
  * `public class Java8APISuite extends LocalJavaStreamingContext 
implements Serializable `
  * `public class Java8DatasetAggregatorSuite extends 
JavaDatasetAggregatorSuiteBase `
  * `class JDK8ScalaSuite extends SparkFunSuite with SharedSparkContext `
  * `public class JavaDatasetAggregatorSuite extends 
JavaDatasetAggregatorSuiteBase `
  * `  static class IntSumOf extends Aggregator, 
Integer, Integer> `
  * `public class JavaDatasetAggregatorSuiteBase implements Serializable `
  * `public class JavaSaveLoadSuite `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-82488
  
**[Test build #3029 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3029/consoleFull)**
 for PR 13364 at commit 
[`f44883f`](https://github.com/apache/spark/commit/f44883f2d0d16d3554c332f485b4a53a0ab41a76).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-73874
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59527/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-73872
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-73757
  
**[Test build #59527 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59527/consoleFull)**
 for PR 13364 at commit 
[`f44883f`](https://github.com/apache/spark/commit/f44883f2d0d16d3554c332f485b4a53a0ab41a76).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `public class Java8RDDAPISuite implements Serializable `
  * `public class Java8APISuite extends LocalJavaStreamingContext 
implements Serializable `
  * `public class Java8DatasetAggregatorSuite extends 
JavaDatasetAggregatorSuiteBase `
  * `class JDK8ScalaSuite extends SparkFunSuite with SharedSparkContext `
  * `public class JavaDatasetAggregatorSuite extends 
JavaDatasetAggregatorSuiteBase `
  * `  static class IntSumOf extends Aggregator, 
Integer, Integer> `
  * `public class JavaDatasetAggregatorSuiteBase implements Serializable `
  * `public class JavaSaveLoadSuite `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13364#discussion_r64971955
  
--- Diff: 
external/java8-tests/src/test/java/test/org/apache/spark/java8/Java8RDDAPISuite.java
 ---
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.spark;
+package test.org.apache.spark.java8;
--- End diff --

the java8 part is to make it easier to run all java 8 tests. not that big 
of a deal though. the more important one is to make the beginning part 
consistent.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-62239
  
**[Test build #59527 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59527/consoleFull)**
 for PR 13364 at commit 
[`f44883f`](https://github.com/apache/spark/commit/f44883f2d0d16d3554c332f485b4a53a0ab41a76).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/13364#discussion_r64971647
  
--- Diff: 
external/java8-tests/src/test/java/test/org/apache/spark/java8/Java8RDDAPISuite.java
 ---
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.spark;
+package test.org.apache.spark.java8;
--- End diff --

Yeah, core tests use `test.org.apache.spark` to specifically test from 
outside the same package. Is `.java8` needed? I don't particularly care much 
myself. Some scala tests use `org.apache.sparktest`, unfortunately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[rxin]

GitHub user rxin opened a pull request:

https://github.com/apache/spark/pull/13364

[SPARK-15633][minor] Make package name for Java tests consistent

## What changes were proposed in this pull request?
This is a simple patch that makes package names for Java 8 test suites 
consistent. I moved everything to test.org.apache.spark to we can test package 
private APIs properly. Also added "java8" as the package name so we can easily 
run all the tests related to Java 8.

## How was this patch tested?
This is a test only change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rxin/spark SPARK-15633

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13364






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15633][minor] Make package name for Jav...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13364#issuecomment-61538
  
cc @andrewor14  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org