[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-118162504 [Test build #36422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36422/console) for PR 7169 at commit [`a8353db`](https://github.com/apache/spark/commit/a8353db18d9f8ab931caf0e93e456d41094345f4). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-118162715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-118165913 Merging into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-118116919 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-118116885 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-118117137 [Test build #36422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36422/consoleFull) for PR 7169 at commit [`a8353db`](https://github.com/apache/spark/commit/a8353db18d9f8ab931caf0e93e456d41094345f4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
GitHub user deroneriksson opened a pull request: https://github.com/apache/spark/pull/7169 [SPARK-1564] [Docs] Added Javascript to Javadocs to create badges for tags like :: Experimental :: Modified copy_api_dirs.rb and created api-javadocs.js and api-javadocs.css files in order to add badges to javadoc files for :: Experimental ::, :: DeveloperApi ::, and :: AlphaComponent :: tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/deroneriksson/spark SPARK-1564_JavaDocs_badges Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7169 commit 65b493072eb385ef25151a6485369f801730c760 Author: Deron Eriksson de...@us.ibm.com Date: 2015-07-01T21:08:43Z Modified copy_api_dirs.rb and created api-javadocs.js and api-javadocs.css files in order to add badges to javadoc files for :: Experimental ::, :: DeveloperApi ::, and :: AlphaComponent :: tags --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117831150 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117831126 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117833756 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117828197 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117830367 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117831769 [Test build #36304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36304/consoleFull) for PR 7169 at commit [`65b4930`](https://github.com/apache/spark/commit/65b493072eb385ef25151a6485369f801730c760). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117833680 [Test build #36304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36304/console) for PR 7169 at commit [`65b4930`](https://github.com/apache/spark/commit/65b493072eb385ef25151a6485369f801730c760). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class FlumeUtils(object):` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/7169#discussion_r33741997 --- Diff: docs/css/api-javadocs.css --- @@ -0,0 +1,35 @@ +/* Dynamically injected style for the API docs */ --- End diff -- Could you add a license header? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117840295 This is amazing! Do you mind pasting a screenshot? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user deroneriksson commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117844563 Here's a screenshot:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7169#discussion_r33739608
--- Diff: docs/js/api-javadocs.js ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* Dynamically injected post-processing code for the API docs */
+
+$(document).ready(function() {
+ addBadges(:: AlphaComponent ::, 'span class=alphaComponent
badgeAlpha Component/span');
+ addBadges(:: DeveloperApi ::, 'span class=developer badgeDeveloper
API/span');
+ addBadges(:: Experimental ::, 'span class=experimental
badgeExperimental/span');
+});
+
+function addBadges(tag, html) {
+ var tags = $(.block:contains( + tag + ))
+
+ // Remove identifier tags
+ tags.each(function(index) {
+var oldHTML = $(this).html();
+var newHTML = oldHTML.replace(tag, );
+$(this).html(newHTML);
+ });
+
+ // Add html badge tags
+ tags.each(function(index) {
+if ($(this).parent().is('td.colLast')) {
+ $(this).parent().prepend(html);
+} else if
($(this).parent('li.blockList').parent('ul.blockList').parent('div.description').parent().is('div.contentContainer'))
{
+ var contentContainer =
$(this).parent('li.blockList').parent('ul.blockList').parent('div.description').parent('div.contentContainer')
--- End diff --
these two lines are super long! Could you rewrite them in a way that's
easier to read? Maybe add line breaks after each `.parent(...)` block?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-1564] [Docs] Added Javascript to Javado...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7169#issuecomment-117864570 @deroneriksson looks great. Thanks for working on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
