[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13406


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/13406
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/13406
  
Merging into master 2.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13406
  
cc @yhuai


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65269018
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

Oh, you're right. I checked out your PR locally and tested a minute ago.
I was completely wrong at this. So sorry!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65265548
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

I still don't get it. There is no trailing whitespace (I deleted it), and 
there is an extra blank line. What are you looking for exactly?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65265445
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

Sorry I still have no idea what you are talking about. Would it fail the 
style test if there was none?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65265296
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

This file is not covered by Scalastyle since it's in `src/java`.
But again, it's not worth of wasting your time. You can merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65264904
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

Now. I see what you mean. We are mentioning different one.
Your example is about `carriage return`.
What I meat is `org.scalastyle.file.WhitespaceEndOfLineChecker`. 
In 'src/scala', please choose one scala file and delete the last empty line 
and run `dev/scalastyle`.
You can see the violation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65264316
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

@rxin . Yep. It's not worth of it.
Let's forget about this for now.
Please never mind my last comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65264246
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

Yes I'm pretty sure you are wrong. See 
https://github.com/apache/spark/pull/13423/files#diff-c8ebb678d9e773dd03e05b0bca473d17R25
 for an example of a file lacking a new blank line.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65263287
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

In my PR, there is line 26.


https://github.com/apache/spark/pull/13404/files#diff-c8ebb678d9e773dd03e05b0bca473d17R26

Did I miss something? I think I'm bothering you in this PR. :)
If you don't want to update this PR. I'll reopen mine again to show it 
clearly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65263190
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

I'm pretty sure it's already there, because otherwise git would show a red 
mark at the end. Also I verified locally by running wc (if I remove the 
trailing new line, wc result goes from 25 to 24).

But more importantly, why are we wasting time here?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65262391
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

It isn't there. Apache Git Repository shows that line 25 is the last one.
```
  20 /**
  21  * Set of interfaces to represent functions in Spark's Java API. Users 
create implementations of
  22  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  23  * Java programming guide for more details.
  24  */
  25 package object function 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65259546
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

it is there isn't it?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65249012
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

What I meat is we need a line blank line at line number 26. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65240101
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

Could you take a look my PR again? Or, 


https://git-wip-us.apache.org/repos/asf?p=spark.git;a=blob;f=core/src/main/java/org/apache/spark/api/java/function/package.scala;h=0f9bac716416264aeba175b90c0b32570bc6dd81;hb=HEAD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65215816
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

otherwise github shows a red sign at the end i think


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65215714
  
--- Diff: 
core/src/main/java/org/apache/spark/api/java/function/package.scala ---
@@ -22,4 +22,4 @@ package org.apache.spark.api.java
  * these interfaces to pass functions to various Java API methods for 
Spark. Please visit Spark's
  * Java programming guide for more details.
  */
-package object function 
+package object function
--- End diff --

there is already a new line here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15662][SQL] Add since annotation for classes in s...

[rxin]

Github user rxin commented on a diff in the pull request:

https://github.com/apache/spark/pull/13406#discussion_r65214361
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala ---
@@ -25,6 +25,14 @@ import 
org.apache.spark.sql.catalyst.DefinedByConstructorParams
 // Note: all classes here are expected to be wrapped in Datasets and so 
must extend
 // DefinedByConstructorParams for the catalog to be able to create 
encoders for them.
 
+/**
+ * A database in Spark, as returned by the `listDatabases` method defined 
in [[Catalog]].
--- End diff --

There are multiple of them so these links won't work.

On Tuesday, May 31, 2016, Jacek Laskowski  wrote:

> In sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala
> :
>
> > @@ -25,6 +25,14 @@ import 
org.apache.spark.sql.catalyst.DefinedByConstructorParams
> >  // Note: all classes here are expected to be wrapped in Datasets and 
so must extend
> >  // DefinedByConstructorParams for the catalog to be able to create 
encoders for them.
> >
> > +/**
> > + * A database in Spark, as returned by the `listDatabases` method 
defined in [[Catalog]].
>
> Use [[Catalog#listDatabases]]
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org