[GitHub] spark pull request: [SPARK-2188] Support sbt/sbt for Windows
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3591 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2188] Support sbt/sbt for Windows
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3591#issuecomment-75148892 Hi @tsudukim thanks a lot for working on this. As others have mentioned, we should avoid having to maintain these scripts ourselves in Spark. Also, we don't try to tie Spark to a particular build tool (SBT or Maven), so supporting SBT here means we should support Maven too, which is way too much overhead. For this reason I would recommend that we close this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2188] Support sbt/sbt for Windows
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/3591#issuecomment-65837669 I wonder which is good but I tend not to think to submit this to upstream. It is a good idea if this was made from the latest sbt script, but unfortunately this is made from our sbt script which is an old version. If we would try to submit this to upstream, we should update this as equivalent to the latest sbt, which means the updated windows script will differ from our current linux sbt script so it will be more difficult to maintain. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2188] Support sbt/sbt for Windows
Github user tsudukim commented on the pull request: https://github.com/apache/spark/pull/3591#issuecomment-65638788 @pwendell Thank you for your comment. I quite agree that Windows script like .cmd or .bat is very high cost for maintainance, but this time I used PowerShell which is a scripting language differently from .cmd or .bat. You can see the script inside. Linux version and PowerShell version have same structure (functions, variables, ...) so I think it's easier to read or modify. And Yes, I use Windows for daily Spark development. For sbt and maven, sbt is much better for trial and erro development as you know. I think the reason why I want sbt is the same as why we use sbt rather than maven for development on linux. I also use maven as a final check, but sbt is more useful for continuous development. About cygwin, I'm not using cygwin. Cygwin environment is so polluted by cygwin functions or cygwin variables that the behavior of Windows becomes strange. That's critical for enterprise systems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2188] Support sbt/sbt for Windows
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3591#issuecomment-65687621 Our `sbt` shell scripts are from the [sbt-launcher-package](https://github.com/sbt/sbt-launcher-package) project. Do you think we should try to submit this change upstream first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
