[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1146#discussion_r14007790
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTypeCoercionSuite.scala
---
@@ -28,4 +32,23 @@ class HiveTypeCoercionSuite extends HiveComparisonTest {
createQueryTest(s$i + $j, sSELECT $i + $j FROM src LIMIT 1)
}
}
+
+ test([SPARK-2210] boolean cast on boolean value should be removed) {
+val q = select cast(cast(key=0 as boolean) as boolean) from src
+val project = TestHive.hql(q).queryExecution.executedPlan.collect {
case e: Project = e }.head
+
+// No cast expression introduced
+project.transformAllExpressions { case c: Cast =
+ assert(false, unexpected cast + c)
+ c
+}
+
+// Only one EqualsTo
+var numEquals = 0
+project.transformAllExpressions { case e: EqualsTo =
+ numEquals += 1
+ e
+}
+assert(numEquals === 1)
--- End diff --
I think this can be simplified to:
```scala
assert(project.collect { case e: EqualsTo = e }.size === 1)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46647411 LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46647638 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46649921 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46649918 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46650780 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46650787 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46650779 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46650781 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15943/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651364 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651365 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15949/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651438 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651648 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651658 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651721 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46651722 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15945/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46652247 Ok merging this in master branch-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46654453 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15947/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46654451 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2218] rename Equals to EqualTo in Spark...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1146#issuecomment-46656824 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15950/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
