[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread ueshin
GitHub user ueshin opened a pull request:

https://github.com/apache/spark/pull/1357

[SPARK-2431][SQL] Refine StringComparison and related codes.

Refine `StringComparison` and related codes as follows:
- `StringComparison` could be similar to `StringRegexExpression` or 
`CaseConversionExpression`.
- Nullability of `StringRegexExpression` could depend on children's 
nullabilities.
- Add a case that the like condition includes no wildcard to 
`LikeSimplification`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ueshin/apache-spark issues/SPARK-2431

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/1357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1357


commit 680bb72ee0dafaeae34dbc3dbff3984f856b5e18
Author: Takuya UESHIN ues...@happy-camper.st
Date:   2014-07-10T15:49:07Z

Refine StringComparison.

commit b9da9d21da49f7d92c9b194173805b1a627e841b
Author: Takuya UESHIN ues...@happy-camper.st
Date:   2014-07-10T15:49:55Z

Fix nullability of StringRegexExpression.

commit 77766f55c331dac2f81f657d7aedb06538b29c41
Author: Takuya UESHIN ues...@happy-camper.st
Date:   2014-07-10T15:54:46Z

Add a case that the like condition includes no wildcard to 
LikeSimplification.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1357#issuecomment-48629241
  
 Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1357#issuecomment-48629261
  
Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1357#issuecomment-48629390
  
QA tests have started for PR 1357. This patch merges cleanly. brView 
progress: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16503/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1357#issuecomment-48641969
  
All automated tests passed.
Refer to this link for build results: 
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16503/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/1357#issuecomment-48641968
  
Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/1357#issuecomment-48641953
  
QA results for PR 1357:br- This patch PASSES unit tests.br- This patch 
merges cleanlybr- This patch adds the following public classes 
(experimental):brtrait StringComparison {brcase class Contains(left: 
Expression, right: Expression)brcase class StartsWith(left: Expression, 
right: Expression)brcase class EndsWith(left: Expression, right: 
Expression)brbrFor more information see test 
ouptut:brhttps://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16503/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] spark pull request: [SPARK-2431][SQL] Refine StringComparison and ...

2014-07-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/1357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---