[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1366 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1366#issuecomment-48821086 Merging this in master & branch-1.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1366#issuecomment-48759522 @aarondav, you are totally right. However, the `Aggregate` operator that this is replacing made the same assumption and this approach will use strictly less memory. For the 1.2 release I'd like to focus on external algorithms and hopefully start using more of sparks built in data structures for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1366#issuecomment-48698130 This operation seems to assume that a single partition fits in memory -- perhaps this is an assumption of SparkSQL, but it is not a general assumption in Spark, and it can lead to some very hard-to-diagnose failure conditions. Has this been taken into account? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1366#issuecomment-48685130
QA results for PR 1366:- This patch PASSES unit tests.- This patch
merges cleanly- This patch adds the following public classes
(experimental):case class Distinct(partial: Boolean, child: SparkPlan)
extends UnaryNode {For more information see test
ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16535/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1366#issuecomment-48679422 QA tests have started for PR 1366. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16535/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2441][SQL] Add more efficient distinct ...
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/1366 [SPARK-2441][SQL] Add more efficient distinct operator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/marmbrus/spark partialDistinct Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1366 commit 12a31abb263ab356a3255bce0c80a41f82bd9e63 Author: Michael Armbrust Date: 2014-07-10T23:43:07Z Add more efficient distinct operator. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
