[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48998885 QA results for PR 1412:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16662/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48997884 LGTM, merging into master and branch-1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48995408 QA results for PR 1412:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16657/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48993050 QA tests have started for PR 1412. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16662/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48991702 QA results for PR 1412:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16659/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48991556 QA tests have started for PR 1412. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16659/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48990687 QA tests have started for PR 1412. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16657/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1412#discussion_r14917366
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -50,7 +50,7 @@ private[hive] class HiveMetastoreCatalog(hive:
HiveContext) extends Catalog with
def lookupRelation(
db: Option[String],
tableName: String,
- alias: Option[String]): LogicalPlan = {
+ alias: Option[String]): LogicalPlan = client.synchronized {
--- End diff --
Better safe... fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1412#discussion_r14917306
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -50,7 +50,7 @@ private[hive] class HiveMetastoreCatalog(hive:
HiveContext) extends Catalog with
def lookupRelation(
db: Option[String],
tableName: String,
- alias: Option[String]): LogicalPlan = {
+ alias: Option[String]): LogicalPlan = client.synchronized {
--- End diff --
Since we just had a problem with this in Spark core, I want to point out
that locking other people's objects can lead to deadlock if they use
synchronization on `this` internally. Indeed, this Hive object seems like a
relatively prime candidate for this type of trouble since it's gotten through a
static constructor (so is cache-able) and it's Hive (so is probably not
inherently good at thread safety).
Just pointing this out, perhaps it's not a risk in this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48988475 QA results for PR 1412:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16649/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1412#issuecomment-48983895 QA tests have started for PR 1412. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16649/consoleFull --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] spark pull request: [SPARK-2485][SQL] Lock usage of hive client.
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/1412 [SPARK-2485][SQL] Lock usage of hive client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/marmbrus/spark lockHiveClient Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/1412.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1412 commit a6edc5f7521cef3ec0ccd005efaae7d5a8a1ec78 Author: Michael Armbrust Date: 2014-07-15T02:21:53Z Lock usage of hive client. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
