[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67467429 [Test build #24588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24588/consoleFull) for PR 3348 at commit [`fd28e4d`](https://github.com/apache/spark/commit/fd28e4d9e807e677a29451ee361ff040927ffc02). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67474669 [Test build #24588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24588/consoleFull) for PR 3348 at commit [`fd28e4d`](https://github.com/apache/spark/commit/fd28e4d9e807e677a29451ee361ff040927ffc02). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67474674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24588/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67596915 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3348#discussion_r22003183
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -168,4 +168,9 @@ class SQLQuerySuite extends QueryTest {
checkAnswer(sql(SELECT key FROM src WHERE key not between 0 and 10
order by key),
sql(SELECT key FROM src WHERE key between 11 and 500 order by
key).collect().toSeq)
}
+
+test(SPARK-2554 SumDistinct partial aggregation) {
--- End diff --
indentation is off here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3348#discussion_r22003211
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -360,11 +360,11 @@ case class Sum(child: Expression) extends
PartialAggregate with trees.UnaryNode[
override def newInstance() = new SumFunction(child, this)
}
-case class SumDistinct(child: Expression)
- extends AggregateExpression with trees.UnaryNode[Expression] {
+case class SumDistinct(child: Expression)
--- End diff --
avoid trailing whitespace.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-67392120 Minor style comments otherwise LGTM. Thanks for working on this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user ravipesala commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65766741 I have Rebased with master,Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65400232 [Test build #24092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24092/consoleFull) for PR 3348 at commit [`32fe234`](https://github.com/apache/spark/commit/32fe2342eb19bb9b2f43b305bc37e841c049d0c1). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65401372 [Test build #24092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24092/consoleFull) for PR 3348 at commit [`32fe234`](https://github.com/apache/spark/commit/32fe2342eb19bb9b2f43b305bc37e841c049d0c1). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class SumDistinct(child: Expression) ` * `case class CombineSetsAndSum(inputSet: Expression, base: Expression) extends AggregateExpression ` * `case class CombineSetsAndSumFunction(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65401376 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24092/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65404728 [Test build #24093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24093/consoleFull) for PR 3348 at commit [`e60e67f`](https://github.com/apache/spark/commit/e60e67f67b58862f26d651c1155b4755bf2f7456). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65413264 [Test build #24093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24093/consoleFull) for PR 3348 at commit [`e60e67f`](https://github.com/apache/spark/commit/e60e67f67b58862f26d651c1155b4755bf2f7456). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class SumDistinct(child: Expression) ` * `case class CombineSetsAndSum(inputSet: Expression, base: Expression) extends AggregateExpression ` * `case class CombineSetsAndSumFunction(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65413277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24093/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65163018 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65163386 [Test build #24007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24007/consoleFull) for PR 3348 at commit [`4a31ca7`](https://github.com/apache/spark/commit/4a31ca75dc44ff239a829ef1ba4a19a63042ce92). * This patch **does not merge cleanly**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65172947 [Test build #24007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24007/consoleFull) for PR 3348 at commit [`4a31ca7`](https://github.com/apache/spark/commit/4a31ca75dc44ff239a829ef1ba4a19a63042ce92). * This patch **passes all tests**. * This patch **does not merge cleanly**. * This patch adds the following public classes _(experimental)_: * `case class SumDistinct(child: Expression) ` * `case class CombineSetsAndSum(inputSet: Expression, base: Expression) extends AggregateExpression ` * `case class CombineSetsAndSumFunction(` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-65172953 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24007/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
GitHub user ravipesala opened a pull request: https://github.com/apache/spark/pull/3348 [SPARK-2554][SQL] Supporting SumDistinct partial aggregation Adding support to the partial aggregation of SumDistinct You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravipesala/spark SPARK-2554 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3348 commit 4a31ca75dc44ff239a829ef1ba4a19a63042ce92 Author: ravipesala ravindra.pes...@huawei.com Date: 2014-11-18T21:01:32Z Supporting SumDistinct partial aggregation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-2554][SQL] Supporting SumDistinct parti...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3348#issuecomment-63545561 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
