[GitHub] spark pull request: [SPARK-3515][SQL] Moves test suite setup code ...
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/2375 [SPARK-3515][SQL] Moves test suite setup code to beforeAll rather than in constructor Please refer to the JIRA ticket for details. **NOTE** We should check all test suites that do similar initialization-like side effects in their constructors. This PR only fixes `ParquetMetastoreSuite` because it breaks our Jenkins Maven build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark say-no-to-constructor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2375 commit 0ceb75b56022717663b5f35813f26fe911044553 Author: Cheng Lian lian.cs@gmail.com Date: 2014-09-13T00:09:12Z Moves test suite setup code to beforeAll rather than in constructor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3515][SQL] Moves test suite setup code ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2375#issuecomment-55476010 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20242/consoleFull) for PR 2375 at commit [`0ceb75b`](https://github.com/apache/spark/commit/0ceb75b56022717663b5f35813f26fe911044553). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3515][SQL] Moves test suite setup code ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2375#issuecomment-55478990 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20242/consoleFull) for PR 2375 at commit [`0ceb75b`](https://github.com/apache/spark/commit/0ceb75b56022717663b5f35813f26fe911044553). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * ` throw new IllegalStateException(The main method in the given main class must be static)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3515][SQL] Moves test suite setup code ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2375#issuecomment-55480184 Thanks! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3515][SQL] Moves test suite setup code ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
