[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-57006456 Thanks :) Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56621308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20740/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56621305 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20740/consoleFull) for PR 2396 at commit [`2458229`](https://github.com/apache/spark/commit/2458229f03a216c46076a5a87a473aa1ea3bc382). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56620753 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20739/consoleFull) for PR 2396 at commit [`2458229`](https://github.com/apache/spark/commit/2458229f03a216c46076a5a87a473aa1ea3bc382). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56620755 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20739/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56618731 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20740/consoleFull) for PR 2396 at commit [`2458229`](https://github.com/apache/spark/commit/2458229f03a216c46076a5a87a473aa1ea3bc382). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56618520 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56618344 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20738/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-56618196 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20739/consoleFull) for PR 2396 at commit [`2458229`](https://github.com/apache/spark/commit/2458229f03a216c46076a5a87a473aa1ea3bc382). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17951394
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -246,6 +246,7 @@ object HiveMetastoreTypes extends RegexParsers {
case BooleanType => "boolean"
case DecimalType => "decimal"
case TimestampType => "timestamp"
+case NullType => "string"
--- End diff --
Yeah, `void` is better :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17930870
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -246,6 +246,7 @@ object HiveMetastoreTypes extends RegexParsers {
case BooleanType => "boolean"
case DecimalType => "decimal"
case TimestampType => "timestamp"
+case NullType => "string"
--- End diff --
I modified `runSqlHive` in `HiveContext` print out the schema and ran your
test query from below. The schema was:
`Schema(fieldSchemas:[FieldSchema(name:_c0, type:void, comment:null)],
properties:null)`, so I think `void` might be a better option here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-55848362 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20446/consoleFull) for PR 2396 at commit [`ac4fb5d`](https://github.com/apache/spark/commit/ac4fb5dfacedf068cc103c02de50422d7739d927). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-55844173 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20446/consoleFull) for PR 2396 at commit [`ac4fb5d`](https://github.com/apache/spark/commit/ac4fb5dfacedf068cc103c02de50422d7739d927). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17643762
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -246,6 +246,7 @@ object HiveMetastoreTypes extends RegexParsers {
case BooleanType => "boolean"
case DecimalType => "decimal"
case TimestampType => "timestamp"
+case NullType => "string"
--- End diff --
Actually this is what Hive return by executing "explain select null from
src limit 1".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-55843956 Thanks, Michael, I've moved the test as a query test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17622320
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -246,6 +246,7 @@ object HiveMetastoreTypes extends RegexParsers {
case BooleanType => "boolean"
case DecimalType => "decimal"
case TimestampType => "timestamp"
+case NullType => "string"
--- End diff --
Also I don't actually know the answer here, but is there a `void` type or
something we could use instead of `string`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2396#discussion_r17619067
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
---
@@ -632,6 +632,12 @@ class HiveQuerySuite extends HiveComparisonTest {
clear()
}
+ test("select null from table") {
--- End diff --
Maybe it would be better to create a query test, since then it actually
checks to make sure hive is returning the same answer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-55595820 This is according to how Hive handle immediate null value in queries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-55575850 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20333/consoleFull) for PR 2396 at commit [`0981c42`](https://github.com/apache/spark/commit/0981c4246d267eedf90a232d2b7b8e3aab6b642d). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2396#issuecomment-55568780 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20333/consoleFull) for PR 2396 at commit [`0981c42`](https://github.com/apache/spark/commit/0981c4246d267eedf90a232d2b7b8e3aab6b642d). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3531][SQL]select null from table would ...
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/2396 [SPARK-3531][SQL]select null from table would throw a MatchError You can merge this pull request into a Git repository by running: $ git pull https://github.com/adrian-wang/spark selectnull Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/2396.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2396 commit 0981c4246d267eedf90a232d2b7b8e3aab6b642d Author: Daoyuan Wang Date: 2014-09-15T09:16:37Z fix select null from table --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
